From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73D1FC433FE for ; Mon, 24 Oct 2022 03:09:28 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Mwg5y5pJVz3cC5 for ; Mon, 24 Oct 2022 14:09:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=russell.cc header.i=@russell.cc header.a=rsa-sha256 header.s=fm1 header.b=Sq5cz7o8; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=ZUgX565f; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=russell.cc (client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com; envelope-from=ruscur@russell.cc; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=russell.cc header.i=@russell.cc header.a=rsa-sha256 header.s=fm1 header.b=Sq5cz7o8; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=ZUgX565f; dkim-atps=neutral Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Mwg4y3wtdz2xJN for ; Mon, 24 Oct 2022 14:08:34 +1100 (AEDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9F0975C0076; Sun, 23 Oct 2022 23:08:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 23 Oct 2022 23:08:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=russell.cc; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1666580912; x= 1666667312; bh=wbs8CojDDdLchxVZ/SuPyz6Ay9H3J/UdX6f+0tnCJRk=; b=S q5cz7o8ouu5UbphbIndpxAkPnXfgCUU+a9LwBmncIu59NrvBSjKdLEl2TZhY8Ygs XgPX69QKaeXHaBtHOto+yNJUO+vwLD/cspxkhT/3Xw8RI5qyZvMXaQukCQV3aKjv fvpYF7+BwtzTzJiATRnFKBdMBjCBqbIRrAWYaFZDvNPJI+m8oNWmR+JOkRu0i063 CogVSE2/lFEMuTpFEHlfaybSXz2ncr/dF3Hb72H60xGWuJ63AP489QhKlMB0+jhn Rsk0RNg3A/ThO0vewluDWR19PL7EbKTTDIcipjhS1SWDJPUODIKdi7ILHvhxS0O7 CYerlWioNjScCfTXwv8fg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666580912; x= 1666667312; bh=wbs8CojDDdLchxVZ/SuPyz6Ay9H3J/UdX6f+0tnCJRk=; b=Z UgX565fYaaWqcVRl/sCG2v+8xu6kr08+7J6F9Z9N29ggoC/jeceQCuxolbM/mGil 1IbWbEDzG2/pyEB9jcolYNgKx9pfBjsWgJue/AVRiWT7wIotv1QBu29ycyTOXyIv 10QMd2RbzbJpYset+gORIRXCOhxa8tQXpPI2A08Zb0WP+HEErnF7Ws9tH6b8SEhe g0gx5fhKeqdEhd3RRnAvbvXP9t1OQBSDcGm1sTmdVisydl+51qGNoqI9Z9YpuIoS cFunHRon+DEWIv/CFwws4eRrCmVeOHNaPI3dY6hV7H/B1HApYJ3tvbnWxTkzoOKJ nXK+OkQSXBv8uUX0wwu0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedtfedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdluddtmdenucfjughrpefkuffhvfevffgjfhgtgfgfggesthhqredt tderjeenucfhrhhomheptfhushhsvghllhcuvehurhhrvgihuceorhhushgtuhhrsehruh hsshgvlhhlrdgttgeqnecuggftrfgrthhtvghrnheptefgieelhfeufeevvdekheeifeej gfefgeehtedukeeigfduuddtueekteevleelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomheprhhushgtuhhrsehruhhsshgvlhhlrdgttg X-ME-Proxy: Feedback-ID: i4421424f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 23 Oct 2022 23:08:30 -0400 (EDT) Message-ID: <51ad065e97e6cd21786a024299722479d31da99f.camel@russell.cc> Subject: Re: [PATCH v8 2/6] powerpc/code-patching: Use WARN_ON and fix check in poking_init From: Russell Currey To: Benjamin Gray , linuxppc-dev@lists.ozlabs.org Date: Mon, 24 Oct 2022 14:08:28 +1100 In-Reply-To: <20221021052238.580986-3-bgray@linux.ibm.com> References: <20221021052238.580986-1-bgray@linux.ibm.com> <20221021052238.580986-3-bgray@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jniethe5@gmail.com, cmr@bluescreens.de, npiggin@gmail.com, ajd@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 2022-10-21 at 16:22 +1100, Benjamin Gray wrote: > From: "Christopher M. Riedl" >=20 > The latest kernel docs list BUG_ON() as 'deprecated' and that they > should be replaced with WARN_ON() (or pr_warn()) when possible. The > BUG_ON() in poking_init() warrants a WARN_ON() rather than a > pr_warn() > since the error condition is deemed "unreachable". >=20 > Also take this opportunity to fix the failure check in the WARN_ON(): > cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, ...) returns a positive > integer > on success and a negative integer on failure. >=20 > Signed-off-by: Benjamin Gray Reviewed-by: Russell Currey