From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1FB3C433F5 for ; Tue, 15 Mar 2022 17:14:55 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KJ0QQ2NbVz3bTc for ; Wed, 16 Mar 2022 04:14:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MeQhR9uz; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jK7qNJyN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=david@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MeQhR9uz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jK7qNJyN; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KJ0Pd51hQz2x9V for ; Wed, 16 Mar 2022 04:14:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647364449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FsVY1kXB4ioI1J1uyDxz0dDFxgjXb4CnXzGjz5blmOc=; b=MeQhR9uz0Pg+dnI/SnSTETxSw/gCdYxR2n0utVRfYkEzJnQzpsLr3CcdIDwuzWtdxLlryu JAChTol/GNeesZtYQCyfoc7Kv0u+mUec+Uh8bwVtAL3GtRzgnV8mf8oxoxqmgMxstN6Z8B E6X3NiEhwpVvmt0+gcKh1QVgC444eKQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647364450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FsVY1kXB4ioI1J1uyDxz0dDFxgjXb4CnXzGjz5blmOc=; b=jK7qNJyNLNLvNedzZc1p/IIn2ASX2Np0ylSOvwTtkUL0P6w+bH/VoJiZ8TM/asARHXEgGM BfNoEHF+YiWYMvmlnrFWrjj8H4Wi9pxbZbYnJMpZJ95GmMjscs0DfiENLcb9n+OrcbLpyg aXSH9f7y4JNtuX47qzfk1EqUG+fAbus= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-313-_7DH4xFxMeK-JrFPBP8mhQ-1; Tue, 15 Mar 2022 13:14:08 -0400 X-MC-Unique: _7DH4xFxMeK-JrFPBP8mhQ-1 Received: by mail-wm1-f72.google.com with SMTP id k26-20020a05600c0b5a00b0038c6c41159bso17793wmr.0 for ; Tue, 15 Mar 2022 10:14:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:organization:in-reply-to :content-transfer-encoding; bh=FsVY1kXB4ioI1J1uyDxz0dDFxgjXb4CnXzGjz5blmOc=; b=6C04sctqXuiv7WPeHCaBSylESkIq/i+MR2KdeTbBIhZ97656TBmJfv7n7hMJFpNUJc 6wmUp4rAg9Hk+tZm5nHvzKBIJ8KNY17SfNYS4KyQYcx2Xe33wxtBOUooF1YH0VYvqRNZ eFZZ6V5DjGx9JRg/GgIUeFPITKfCO5n+h8cKF6B4bvlnuFSGMQ9qoVBckTy3dwW1Ykzg 5sBC2B4/o7IUJLGBT1PzPQE39uEQzFoyQ2MtkyTorZ8NrjEOnqd+AiJtCItcRRPehVoC BQlVc1PBBTHrgArg8SgP/wLxXFyH/Xgzxeg9ZmUAskxKyIywXstCM5Ok+M4wlenYd9XU 5U7A== X-Gm-Message-State: AOAM532HdG9LL8CzqcUdx45JKPiwtIvwu59OBvvbSFjhVUvnsbUyI/5E WRQmFStIxG98SByqDJqLuJTgcU7OZr3kEeu3vnnvkJOQvEPZZ5ZFXsTZC85Ovyf3vt2WZaJnBj2 YLb2nfvbuOE/5v9QR5ggfryusEw== X-Received: by 2002:adf:db01:0:b0:1f1:dcea:2b7f with SMTP id s1-20020adfdb01000000b001f1dcea2b7fmr21378175wri.598.1647364447498; Tue, 15 Mar 2022 10:14:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdS8qTqdqR219JFpZK+GPZ5bYAnnLa33KsM4wjU9HkrplJGzUCifrTI55X5XaluCKbirwW1w== X-Received: by 2002:adf:db01:0:b0:1f1:dcea:2b7f with SMTP id s1-20020adfdb01000000b001f1dcea2b7fmr21378152wri.598.1647364447236; Tue, 15 Mar 2022 10:14:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:1800:42bd:3cac:d22a:3c62? (p200300cbc708180042bd3cacd22a3c62.dip0.t-ipconnect.de. [2003:cb:c708:1800:42bd:3cac:d22a:3c62]) by smtp.gmail.com with ESMTPSA id c7-20020a5d4f07000000b00203db8f13c6sm466545wru.75.2022.03.15.10.14.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 10:14:06 -0700 (PDT) Message-ID: <51afa7a7-15c5-8769-78db-ed2d134792f4@redhat.com> Date: Tue, 15 Mar 2022 18:14:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v1 5/7] s390/pgtable: support __HAVE_ARCH_PTE_SWP_EXCLUSIVE From: David Hildenbrand To: Gerald Schaefer References: <20220315141837.137118-1-david@redhat.com> <20220315141837.137118-6-david@redhat.com> <20220315172102.771bd2cf@thinkpad> <8b13b6c0-78d4-48e3-06f0-ec0680d013a9@redhat.com> <55b6b582-51ca-b869-2055-674fe4c563e6@redhat.com> Organization: Red Hat In-Reply-To: <55b6b582-51ca-b869-2055-674fe4c563e6@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Jan Kara , Catalin Marinas , Yang Shi , Dave Hansen , Peter Xu , Michal Hocko , linux-mm@kvack.org, Donald Dutile , Liang Zhang , Borislav Petkov , Alexander Gordeev , Will Deacon , Christoph Hellwig , Paul Mackerras , Andrea Arcangeli , linux-s390@vger.kernel.org, Vasily Gorbik , Rik van Riel , Hugh Dickins , Matthew Wilcox , Mike Rapoport , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Jason Gunthorpe , David Rientjes , Pedro Gomes , Jann Horn , John Hubbard , Heiko Carstens , Shakeel Butt , Oleg Nesterov , Thomas Gleixner , Vlastimil Babka , Oded Gabbay , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Nadav Amit , Andrew Morton , Linus Torvalds , Roman Gushchin , "Kirill A . Shutemov" , Mike Kravetz Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 15.03.22 18:12, David Hildenbrand wrote: > On 15.03.22 17:58, David Hildenbrand wrote: >> >>>> This would mean that it is not OK to have bit 52 not zero for swap PTEs. >>>> But if I read the POP correctly, all bits except for the DAT-protection >>>> would be ignored for invalid PTEs, so maybe this comment needs some update >>>> (for both bits 52 and also 55). >>>> >>>> Heiko might also have some more insight. >>> >>> Indeed, I wonder why we should get a specification exception when the >>> PTE is invalid. I'll dig a bit into the PoP. >> >> SA22-7832-12 6-46 ("Translation-Specification Exception") is clearer >> >> "The page-table entry used for the translation is >> valid, and bit position 52 does not contain zero." >> >> "The page-table entry used for the translation is >> valid, EDAT-1 does not apply, the instruction-exe- >> cution-protection facility is not installed, and bit >> position 55 does not contain zero. It is model >> dependent whether this condition is recognized." >> > > I wonder if the following matches reality: > > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index 008a6c856fa4..6a227a8c3712 100644 > --- a/arch/s390/include/asm/pgtable.h > +++ b/arch/s390/include/asm/pgtable.h > @@ -1669,18 +1669,16 @@ static inline int has_transparent_hugepage(void) > /* > * 64 bit swap entry format: > * A page-table entry has some bits we have to treat in a special way. > - * Bits 52 and bit 55 have to be zero, otherwise a specification > - * exception will occur instead of a page translation exception. The > - * specification exception has the bad habit not to store necessary > - * information in the lowcore. > * Bits 54 and 63 are used to indicate the page type. > * A swap pte is indicated by bit pattern (pte & 0x201) == 0x200 > - * This leaves the bits 0-51 and bits 56-62 to store type and offset. > - * We use the 5 bits from 57-61 for the type and the 52 bits from 0-51 > - * for the offset. > - * | offset |01100|type |00| > + * | offset |XX1XX|type |S0| > * |0000000000111111111122222222223333333333444444444455|55555|55566|66| > * |0123456789012345678901234567890123456789012345678901|23456|78901|23| > + * > + * Bits 0-51 store the offset. > + * Bits 57-62 store the type. ^ 57-61, I should stop working for today :) -- Thanks, David / dhildenb