From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40618C433E4 for ; Wed, 26 Aug 2020 15:32:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2B762078A for ; Wed, 26 Aug 2020 15:32:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2B762078A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Bc8xX2039zDqXr for ; Thu, 27 Aug 2020 01:32:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.235.10; helo=pegase2.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Bc8hd2bwLzDqBX for ; Thu, 27 Aug 2020 01:21:16 +1000 (AEST) Received: from localhost (mailhub2-ext [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Bc8hM1ndwz9ttg8; Wed, 26 Aug 2020 17:21:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [172.26.127.65]) (amavisd-new, port 10024) with ESMTP id I4sjrkcRIIM9; Wed, 26 Aug 2020 17:21:07 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Bc8hM118mz9ttg7; Wed, 26 Aug 2020 17:21:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 68A618B84E; Wed, 26 Aug 2020 17:21:10 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id lumH6pwI8T_t; Wed, 26 Aug 2020 17:21:10 +0200 (CEST) Received: from [192.168.204.43] (unknown [192.168.204.43]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 83D148B75F; Wed, 26 Aug 2020 17:21:09 +0200 (CEST) Subject: Re: [PATCH v1 4/9] powerpc/vdso: Remove unnecessary ifdefs in vdso_pagelist initialization To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras References: <834f362626e18bc36226f46ed4113c461a3ad032.1598363608.git.christophe.leroy@csgroup.eu> <87ft89h2st.fsf@mpe.ellerman.id.au> From: Christophe Leroy Message-ID: <51cab2a3-044c-f76b-db3a-490ac7533cd2@csgroup.eu> Date: Wed, 26 Aug 2020 17:21:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87ft89h2st.fsf@mpe.ellerman.id.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 26/08/2020 à 16:58, Michael Ellerman a écrit : > Christophe Leroy writes: >> diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c >> index daef14a284a3..bbb69832fd46 100644 >> --- a/arch/powerpc/kernel/vdso.c >> +++ b/arch/powerpc/kernel/vdso.c >> @@ -718,16 +710,14 @@ static int __init vdso_init(void) > ... >> >> - >> -#ifdef CONFIG_VDSO32 >> vdso32_kbase = &vdso32_start; >> >> /* >> @@ -735,8 +725,6 @@ static int __init vdso_init(void) >> */ >> vdso32_pages = (&vdso32_end - &vdso32_start) >> PAGE_SHIFT; >> DBG("vdso32_kbase: %p, 0x%x pages\n", vdso32_kbase, vdso32_pages); >> -#endif > > This didn't build for ppc64le: > > /opt/cross/gcc-8.20_binutils-2.32/powerpc64-unknown-linux-gnu/bin/powerpc64-unknown-linux-gnu-ld: arch/powerpc/kernel/vdso.o:(.toc+0x0): undefined reference to `vdso32_end' > /opt/cross/gcc-8.20_binutils-2.32/powerpc64-unknown-linux-gnu/bin/powerpc64-unknown-linux-gnu-ld: arch/powerpc/kernel/vdso.o:(.toc+0x8): undefined reference to `vdso32_start' > make[1]: *** [/scratch/michael/build/maint/Makefile:1166: vmlinux] Error 1 > make: *** [Makefile:185: __sub-make] Error 2 > > So I just put that ifdef back. > Argh. I guess that's the DBG() that hurts. I'll think about it. Christophe