From: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Stewart Smith <stewart@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/3] powernv: Fix MCE handler to avoid trashing CR0/CR1 registers.
Date: Thu, 4 Aug 2016 14:27:24 +0530 [thread overview]
Message-ID: <5208d498-ffa8-cf5f-dcae-2f8d0d1b0889@linux.vnet.ibm.com> (raw)
In-Reply-To: <87mvkt891s.fsf@linux.vnet.ibm.com>
On 08/04/2016 09:44 AM, Stewart Smith wrote:
> Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com> writes:
>> From: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
>>
>> The current implementation of MCE early handling modifies CR0/1 registers
>> without saving its old values. Fix this by moving early check for
>> powersaving mode to machine_check_handle_early().
>
> From (internal bug report) it seems as though in a test where one
> injects continuous SLB Multi Hit errors, this bug could lead to rebooting
> "due to to Platform error" rather than continuing to recover
> successfully. It might be a good idea to mention that in commit message
> here.
This patch does not address the specific internal bug that you talking
about. I am still chasing that bug.
>
> Also, should this go to stable?
>
However yes. This should go to stable tree.
next prev parent reply other threads:[~2016-08-04 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 5:47 [PATCH v2 1/3] powernv: Move IDLE_STATE_ENTER_SEQ macro to cpuidle.h Mahesh J Salgaonkar
2016-03-01 5:47 ` [PATCH v2 2/3] powernv: Rename pSeries to powenv from machine_check_pSeries_early Mahesh J Salgaonkar
2016-05-10 21:48 ` [v2, " Michael Ellerman
2016-03-01 5:49 ` [PATCH v2 3/3] powernv: Fix MCE handler to avoid trashing CR0/CR1 registers Mahesh J Salgaonkar
2016-08-04 4:14 ` Stewart Smith
2016-08-04 8:57 ` Mahesh Jagannath Salgaonkar [this message]
2016-08-04 9:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5208d498-ffa8-cf5f-dcae-2f8d0d1b0889@linux.vnet.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=shreyas@linux.vnet.ibm.com \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).