From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [119.145.14.64]) (using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) (Client CN "myname.my.domain", Issuer "www.mirapoint.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id EA9482C0187 for ; Wed, 14 Aug 2013 13:40:01 +1000 (EST) Message-ID: <520AFBF4.1070509@huawei.com> Date: Wed, 14 Aug 2013 11:39:32 +0800 From: Libo Chen MIME-Version: 1.0 To: David Miller , Subject: [PATCH RESEND 2/8] net: ucc_geth: use platform_{get,set}_drvdata() References: <5208E21A.3020805@huawei.com> In-Reply-To: <5208E21A.3020805@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Cc: netdev@vger.kernel.org, Li Zefan , linuxppc-dev@lists.ozlabs.org, LKML List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , We can use the wrapper functions platform_{get,set}_drvdata() instead of dev_{get,set}_drvdata() with &ofdev->dev, it is convenient for user. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL after device_release or on probe failure. Signed-off-by: Libo Chen --- drivers/net/ethernet/freescale/ucc_geth.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c index 3c43dac..5930c39 100644 --- a/drivers/net/ethernet/freescale/ucc_geth.c +++ b/drivers/net/ethernet/freescale/ucc_geth.c @@ -3911,14 +3911,12 @@ static int ucc_geth_probe(struct platform_device* ofdev) static int ucc_geth_remove(struct platform_device* ofdev) { - struct device *device = &ofdev->dev; - struct net_device *dev = dev_get_drvdata(device); + struct net_device *dev = platform_get_drvdata(ofdev); struct ucc_geth_private *ugeth = netdev_priv(dev); unregister_netdev(dev); free_netdev(dev); ucc_geth_memclean(ugeth); - dev_set_drvdata(device, NULL); return 0; } -- 1.7.1