linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	netdev@vger.kernel.org, jg1.han@samsung.com,
	LKML <linux-kernel@vger.kernel.org>,
	Li Zefan <lizefan@huawei.com>,
	vbordug@ru.mvista.com, linuxppc-dev@lists.ozlabs.org,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH RESEND 0/8] use platform_{get,set}_drvdata()
Date: Wed, 14 Aug 2013 22:56:35 +0400	[thread overview]
Message-ID: <520BD2E3.9080606@cogentembedded.com> (raw)
In-Reply-To: <520AFB3F.2090006@huawei.com>

On 08/14/2013 07:36 AM, Libo Chen wrote:

> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
>
> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.

    Saying "also" in the changelog is usually a good sign that the patch 
should be split.

WBR, Sergei

      reply	other threads:[~2013-08-14 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 13:24 use platform_{get,set}_drvdata() Libo Chen
2013-08-14  3:36 ` [PATCH RESEND 0/8] " Libo Chen
2013-08-14 18:56   ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520BD2E3.9080606@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=clbchenlibo.chen@huawei.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).