From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from service87.mimecast.com (service87.mimecast.com [91.220.42.44]) by ozlabs.org (Postfix) with ESMTP id AB75C2C015F for ; Fri, 16 Aug 2013 18:43:14 +1000 (EST) Message-ID: <520DE627.2080007@arm.com> Date: Fri, 16 Aug 2013 09:43:19 +0100 From: Sudeep KarkadaNagesha MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: [RFC PATCH 3/4] powerpc: refactor of_get_cpu_node to support other architectures References: <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376586580-5409-4-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1376628601.4255.138.camel@pasglop> In-Reply-To: <1376628601.4255.138.camel@pasglop> Content-Type: text/plain; charset=UTF-8 Cc: Jonas Bonn , "devicetree@vger.kernel.org" , Michal Simek , "linux-pm@vger.kernel.org" , Sudeep KarkadaNagesha , "microblaze-uclinux@itee.uq.edu.au" , "linux@openrisc.net" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "Rafael J. Wysocki" , "grant.likely@linaro.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 16/08/13 05:50, Benjamin Herrenschmidt wrote: > On Thu, 2013-08-15 at 18:09 +0100, Sudeep KarkadaNagesha wrote: >> /* Check for ibm,ppc-interrupt-server#s. If it doesn't ex= ist >> * fallback to "reg" property and assume no threads >> */ >> - >=20 > Oh and I forgot ... that comment is now wrong, since your code handles > threads in the "reg" case... >=20 I have fixed it in the next patch while adding the documentation to these function. I wanted changes in this patch minimal. I can fix it here too if you insist on it. Regards, Sudeep