From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: paulus@au1.ibm.com, benh@au1.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc/iommu: check dev->iommu_group before remove a device from iommu_group
Date: Fri, 16 Aug 2013 20:15:36 +1000 [thread overview]
Message-ID: <520DFBC8.4040509@ozlabs.ru> (raw)
In-Reply-To: <1376647687-20550-3-git-send-email-weiyang@linux.vnet.ibm.com>
On 08/16/2013 08:08 PM, Wei Yang wrote:
> ---
> arch/powerpc/kernel/iommu.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c
> index b20ff17..5abf7c3 100644
> --- a/arch/powerpc/kernel/iommu.c
> +++ b/arch/powerpc/kernel/iommu.c
> @@ -1149,7 +1149,8 @@ static int iommu_bus_notifier(struct notifier_block *nb,
> case BUS_NOTIFY_ADD_DEVICE:
> return iommu_add_device(dev);
> case BUS_NOTIFY_DEL_DEVICE:
> - iommu_del_device(dev);
> + if (dev->iommu_group)
> + iommu_del_device(dev);
> return 0;
> default:
> return 0;
>
This one seems redundant, no?
--
Alexey
next prev parent reply other threads:[~2013-08-16 10:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 10:08 [PATCH 0/2] powerpc/iommu: check dev->iommu_group before remove it Wei Yang
2013-08-16 10:08 ` [PATCH 1/2] iommu: Don't remove device when no iommu_group associated Wei Yang
2013-08-16 10:08 ` [PATCH 2/2] powerpc/iommu: check dev->iommu_group before remove a device from iommu_group Wei Yang
2013-08-16 10:15 ` Alexey Kardashevskiy [this message]
2013-08-19 1:29 ` Wei Yang
2013-08-19 1:39 ` Alexey Kardashevskiy
2013-08-19 1:55 ` Wei Yang
2013-08-22 7:23 ` Alexey Kardashevskiy
2013-08-22 7:52 ` Wei Yang
2013-08-22 15:28 ` Alex Williamson
2013-08-22 15:41 ` Wei Yang
2013-08-22 16:17 ` Alex Williamson
2013-08-23 1:30 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520DFBC8.4040509@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=benh@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@au1.ibm.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).