From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 0/4] minor fixes for 2.6.26
Date: Tue, 20 May 2008 04:22:40 +0200 [thread overview]
Message-ID: <520c600cfeec1e96d6b4253e2ed9e005@kernel.crashing.org> (raw)
In-Reply-To: <20080520020856.GH22279@yookeroo.seuss>
>>> Arguably this suggests we should rename either the lds files or the
>>> zImages so that we *can* get a pattern to match.
>>
>> Not really. Just define a $(ALL_ZIMAGES) var and use that everywhere.
>> I would be pretty upset if "make clean" decided to delete my
>> zImage.backup,
>> etc.
>
> That won't work for .gitignore.
Sure, * is fine in .gitignore (and then un-ignore the few files you
don't want ignored). .gitignore is just a convenience thing, after
all.
> Besides it's hard to generate, since
> zImage.<allsortsofthings> can be generated based on dts names.
Tricky. But if make can generate the name _at all_ (and it can),
it can do it here, too. It just needs some fairy dust sprinkling.
> Oh, and variables like that are usually a bad idea for clean rules,
> because if new things have just been added/removed from the list, it
> will fail to clean up things built before the makefile change was
> made.
Yes. OTOH, using xx* in "make clean" is an even worse idea.
Segher
next prev parent reply other threads:[~2008-05-20 2:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 18:44 [PATCH 0/4] minor fixes for 2.6.26 Kumar Gala
2008-05-18 18:44 ` [PATCH 1/4] lmb: Fix compile warning Kumar Gala
2008-05-18 18:44 ` [PATCH 2/4] [POWERPC] Remove generated files on make clean Kumar Gala
2008-05-18 18:44 ` [PATCH 3/4] [POWERPC] Update arch/powerpc/boot/.gitignore Kumar Gala
2008-05-18 18:44 ` [PATCH 4/4] [POWERPC] Fix mpc8377_mds.dts DMA nodes to match spec Kumar Gala
2008-05-19 3:31 ` [PATCH 1/4] lmb: Fix compile warning David Miller
2008-05-19 4:34 ` [PATCH v2] " Kumar Gala
2008-05-19 5:09 ` David Miller
2008-05-19 4:37 ` [PATCH 0/4] minor fixes for 2.6.26 Kumar Gala
2008-05-19 23:07 ` Paul Mackerras
2008-05-20 0:54 ` David Gibson
2008-05-20 2:03 ` Segher Boessenkool
2008-05-20 2:08 ` David Gibson
2008-05-20 2:22 ` Segher Boessenkool [this message]
2008-05-20 2:45 ` David Gibson
2008-05-20 4:52 ` Kumar Gala
2008-05-20 5:10 ` David Gibson
2008-05-20 5:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520c600cfeec1e96d6b4253e2ed9e005@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).