From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: In-Reply-To: <20080520020856.GH22279@yookeroo.seuss> References: <1211136296-4572-1-git-send-email-galak@kernel.crashing.org> <0B367446-4628-4633-BF66-A0007BD9A98B@kernel.crashing.org> <18482.2082.900892.368978@cargo.ozlabs.ibm.com> <20080520005401.GD22279@yookeroo.seuss> <20080520020856.GH22279@yookeroo.seuss> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <520c600cfeec1e96d6b4253e2ed9e005@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH 0/4] minor fixes for 2.6.26 Date: Tue, 20 May 2008 04:22:40 +0200 To: David Gibson Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> Arguably this suggests we should rename either the lds files or the >>> zImages so that we *can* get a pattern to match. >> >> Not really. Just define a $(ALL_ZIMAGES) var and use that everywhere. >> I would be pretty upset if "make clean" decided to delete my >> zImage.backup, >> etc. > > That won't work for .gitignore. Sure, * is fine in .gitignore (and then un-ignore the few files you don't want ignored). .gitignore is just a convenience thing, after all. > Besides it's hard to generate, since > zImage. can be generated based on dts names. Tricky. But if make can generate the name _at all_ (and it can), it can do it here, too. It just needs some fairy dust sprinkling. > Oh, and variables like that are usually a bad idea for clean rules, > because if new things have just been added/removed from the list, it > will fail to clean up things built before the makefile change was > made. Yes. OTOH, using xx* in "make clean" is an even worse idea. Segher