From: Roland Dreier <rolandd@cisco.com>
To: mporter@kernel.crashing.org, linuxppc-embedded@ozlabs.org
Subject: [PATCH] PPC: Don't sleep in flush_dcache_icache_page()
Date: Tue, 16 Aug 2005 13:56:49 -0700 [thread overview]
Message-ID: <521x4tha7i.fsf@cisco.com> (raw)
flush_dcache_icache_page() will be called on an instruction page
fault. We can't sleep in the fault handler, so use kmap_atomic()
instead of just kmap() for the Book-E case.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
diff --git a/arch/ppc/mm/init.c b/arch/ppc/mm/init.c
--- a/arch/ppc/mm/init.c
+++ b/arch/ppc/mm/init.c
@@ -560,8 +560,16 @@ void flush_dcache_page(struct page *page
void flush_dcache_icache_page(struct page *page)
{
#ifdef CONFIG_BOOKE
- __flush_dcache_icache(kmap(page));
- kunmap(page);
+ unsigned long flags;
+ void *start;
+
+ local_irq_save(flags);
+
+ start = kmap_atomic(page, KM_PPC_SYNC_PAGE);
+ __flush_dcache_icache(start);
+ kunmap_atomic(start, KM_PPC_SYNC_PAGE);
+
+ local_irq_restore(flags);
#elif CONFIG_8xx
/* On 8xx there is no need to kmap since highmem is not supported */
__flush_dcache_icache(page_address(page));
next reply other threads:[~2005-08-16 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-16 20:56 Roland Dreier [this message]
2005-08-18 17:56 ` [PATCH] PPC: Don't sleep in flush_dcache_icache_page() Marcelo Tosatti
2005-08-18 18:08 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521x4tha7i.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).