* [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS @ 2013-09-03 7:51 Jia Hongtao 2013-09-04 1:27 ` Yang,Wei 0 siblings, 1 reply; 10+ messages in thread From: Jia Hongtao @ 2013-09-03 7:51 UTC (permalink / raw) To: linuxppc-dev, B07421; +Cc: b38951 In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used. Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com> --- arch/powerpc/boot/dts/b4qds.dtsi | 4 ++++ arch/powerpc/boot/dts/t4240qds.dts | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/boot/dts/b4qds.dtsi b/arch/powerpc/boot/dts/b4qds.dtsi index e6d2f8f..2aa3399 100644 --- a/arch/powerpc/boot/dts/b4qds.dtsi +++ b/arch/powerpc/boot/dts/b4qds.dtsi @@ -120,6 +120,10 @@ }; i2c@118000 { + pca9547@77 { + compatible = "philips,pca9547"; + reg = <0x77>; + }; eeprom@50 { compatible = "at24,24c64"; reg = <0x50>; diff --git a/arch/powerpc/boot/dts/t4240qds.dts b/arch/powerpc/boot/dts/t4240qds.dts index 0555976..084db57 100644 --- a/arch/powerpc/boot/dts/t4240qds.dts +++ b/arch/powerpc/boot/dts/t4240qds.dts @@ -118,6 +118,10 @@ }; i2c@118000 { + pca9547@77 { + compatible = "philips,pca9547"; + reg = <0x77>; + }; eeprom@51 { compatible = "at24,24c256"; reg = <0x51>; -- 1.8.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-03 7:51 [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS Jia Hongtao @ 2013-09-04 1:27 ` Yang,Wei 2013-09-04 3:30 ` Tang Yuantian-B29983 2013-09-04 3:37 ` Jia Hongtao-B38951 0 siblings, 2 replies; 10+ messages in thread From: Yang,Wei @ 2013-09-04 1:27 UTC (permalink / raw) To: Jia Hongtao; +Cc: B07421, linuxppc-dev, b38951 On 09/03/2013 03:51 PM, Jia Hongtao wrote: > In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used. Hi Hongtao, If you want to support I2C bus multiplexer, for T4 and B4QDS platform, since some eeprom devices is connected to PCA9574 I2C bus multiplexer, so these devices should be connected to pca9547 node. Just like the following, what do you think of it? + pca9547@77 { + compatible = "philips,pca9547"; + reg = <0x77>; + #address-cells = <1>; + #size-cells = <0>; + channel@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + eeprom@51 { + compatible = "at24,24c256"; + reg = <0x51>; + }; + eeprom@52 { + compatible = "at24,24c256"; + reg = <0x52>; + }; + eeprom@53 { + compatible = "at24,24c256"; + reg = <0x53>; + }; + eeprom@54 { + compatible = "at24,24c256"; + reg = <0x54>; + }; + eeprom@55 { + compatible = "at24,24c256"; + reg = <0x55>; + }; + eeprom@56 { + compatible = "at24,24c256"; + reg = <0x56>; + }; + rtc@68 { + compatible = "dallas,ds3232"; + reg = <0x68>; + interrupts = <0x1 0x1 0 0>; + }; + }; Wei > > Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com> > --- > arch/powerpc/boot/dts/b4qds.dtsi | 4 ++++ > arch/powerpc/boot/dts/t4240qds.dts | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/powerpc/boot/dts/b4qds.dtsi b/arch/powerpc/boot/dts/b4qds.dtsi > index e6d2f8f..2aa3399 100644 > --- a/arch/powerpc/boot/dts/b4qds.dtsi > +++ b/arch/powerpc/boot/dts/b4qds.dtsi > @@ -120,6 +120,10 @@ > }; > > i2c@118000 { > + pca9547@77 { > + compatible = "philips,pca9547"; > + reg = <0x77>; > + }; > eeprom@50 { > compatible = "at24,24c64"; > reg = <0x50>; > diff --git a/arch/powerpc/boot/dts/t4240qds.dts b/arch/powerpc/boot/dts/t4240qds.dts > index 0555976..084db57 100644 > --- a/arch/powerpc/boot/dts/t4240qds.dts > +++ b/arch/powerpc/boot/dts/t4240qds.dts > @@ -118,6 +118,10 @@ > }; > > i2c@118000 { > + pca9547@77 { > + compatible = "philips,pca9547"; > + reg = <0x77>; > + }; > eeprom@51 { > compatible = "at24,24c256"; > reg = <0x51>; ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-04 1:27 ` Yang,Wei @ 2013-09-04 3:30 ` Tang Yuantian-B29983 2013-09-05 18:40 ` Scott Wood 2013-09-04 3:37 ` Jia Hongtao-B38951 1 sibling, 1 reply; 10+ messages in thread From: Tang Yuantian-B29983 @ 2013-09-04 3:30 UTC (permalink / raw) To: Yang,Wei, Jia Hongtao-B38951 Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org, Jia Hongtao-B38951 SGksDQoNClRoZXNlIGVlcHJvbXMgYXJlIG5ldmVyIHVzZWQgYnkga2VybmVsLiBTbyBubyBuZWVk IHRvIGFkZCB0aGVtLg0KDQpUaGFua3MsDQpZdWFudGlhbg0KDQoNCj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gRnJvbTogTGludXhwcGMtZGV2IFttYWlsdG86bGludXhwcGMtZGV2LQ0K PiBib3VuY2VzK2IyOTk4Mz1mcmVlc2NhbGUuY29tQGxpc3RzLm96bGFicy5vcmddIE9uIEJlaGFs ZiBPZiBZYW5nLFdlaQ0KPiBTZW50OiAyMDEzxOo51MI0yNUg0MfG2sj9IDk6MjcNCj4gVG86IEpp YSBIb25ndGFvLUIzODk1MQ0KPiBDYzogV29vZCBTY290dC1CMDc0MjE7IGxpbnV4cHBjLWRldkBs aXN0cy5vemxhYnMub3JnOyBKaWEgSG9uZ3Rhby1CMzg5NTENCj4gU3ViamVjdDogUmU6IFtQQVRD SF0gcG93ZXJwYzogQWRkIEkyQyBidXMgbXVsdGlwbGV4ZXIgbm9kZSBmb3IgQjQgYW5kDQo+IFQ0 MjQwUURTDQo+IA0KPiBPbiAwOS8wMy8yMDEzIDAzOjUxIFBNLCBKaWEgSG9uZ3RhbyB3cm90ZToN Cj4gPiBJbiBib3RoIEI0IGFuZCBUNDI0MFFEUyBwbGF0Zm9ybSBQQ0E5NTQ3IEkyQyBidXMgbXVs dGlwbGV4ZXIgaXMgdXNlZC4NCj4gDQo+IEhpIEhvbmd0YW8sDQo+IA0KPiBJZiB5b3Ugd2FudCB0 byBzdXBwb3J0IEkyQyBidXMgbXVsdGlwbGV4ZXIsIGZvciBUNCBhbmQgQjRRRFMgcGxhdGZvcm0s DQo+IHNpbmNlIHNvbWUgZWVwcm9tIGRldmljZXMgaXMgY29ubmVjdGVkIHRvIFBDQTk1NzQgSTJD IGJ1cyBtdWx0aXBsZXhlciwgc28NCj4gdGhlc2UgZGV2aWNlcyBzaG91bGQgYmUgY29ubmVjdGVk IHRvIHBjYTk1NDcgbm9kZS4gSnVzdCBsaWtlIHRoZQ0KPiBmb2xsb3dpbmcsIHdoYXQgZG8geW91 IHRoaW5rIG9mIGl0Pw0KPiANCj4gKyAgICAgICAgICAgICAgICAgICAgICAgcGNhOTU0N0A3NyB7 DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJwaGlsaXBz LHBjYTk1NDciOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDc3 PjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9IDwx PjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsN Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGFubmVsQDAgew0KPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47DQo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDww PjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwwPjsN Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZWVwcm9t QDUxIHsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb21wYXRpYmxlID0NCj4gImF0MjQsMjRjMjU2IjsNCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHg1MT47DQo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVlcHJvbUA1MiB7 DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29tcGF0aWJsZSA9DQo+ICJhdDI0LDI0YzI1NiI7DQo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4NTI+Ow0KPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTMgew0KPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv bXBhdGlibGUgPQ0KPiAiYXQyNCwyNGMyNTYiOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDUzPjsNCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsNCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZWVwcm9tQDU0IHsNCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRp YmxlID0NCj4gImF0MjQsMjRjMjU2IjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHg1ND47DQo+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVlcHJvbUA1NSB7DQo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9 DQo+ICJhdDI0LDI0YzI1NiI7DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4NTU+Ow0KPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTYgew0KPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPQ0KPiAi YXQyNCwyNGMyNTYiOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJlZyA9IDwweDU2PjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcnRjQDY4IHsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0NCj4gImRhbGxhcyxk czMyMzIiOw0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlZyA9IDwweDY4PjsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1cHRzID0NCj4gPDB4MSAweDEgMCAwPjsN Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsNCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+IA0KPiBXZWkNCj4g Pg0KPiA+IFNpZ25lZC1vZmYtYnk6IEppYSBIb25ndGFvIDxob25ndGFvLmppYUBmcmVlc2NhbGUu Y29tPg0KPiA+IC0tLQ0KPiA+ICAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2I0cWRzLmR0c2kgICB8 IDQgKysrKw0KPiA+ICAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3Q0MjQwcWRzLmR0cyB8IDQgKysr Kw0KPiA+ICAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKykNCj4gPg0KPiA+IGRpZmYg LS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvYjRxZHMuZHRzaQ0KPiA+IGIvYXJjaC9wb3dl cnBjL2Jvb3QvZHRzL2I0cWRzLmR0c2kNCj4gPiBpbmRleCBlNmQyZjhmLi4yYWEzMzk5IDEwMDY0 NA0KPiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNpDQo+ID4gKysrIGIv YXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2I0cWRzLmR0c2kNCj4gPiBAQCAtMTIwLDYgKzEyMCwxMCBA QA0KPiA+ICAgCQl9Ow0KPiA+DQo+ID4gICAJCWkyY0AxMTgwMDAgew0KPiA+ICsJCQlwY2E5NTQ3 QDc3IHsNCj4gPiArCQkJCWNvbXBhdGlibGUgPSAicGhpbGlwcyxwY2E5NTQ3IjsNCj4gPiArCQkJ CXJlZyA9IDwweDc3PjsNCj4gPiArCQkJfTsNCj4gPiAgIAkJCWVlcHJvbUA1MCB7DQo+ID4gICAJ CQkJY29tcGF0aWJsZSA9ICJhdDI0LDI0YzY0IjsNCj4gPiAgIAkJCQlyZWcgPSA8MHg1MD47DQo+ ID4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy90NDI0MHFkcy5kdHMNCj4gPiBi L2FyY2gvcG93ZXJwYy9ib290L2R0cy90NDI0MHFkcy5kdHMNCj4gPiBpbmRleCAwNTU1OTc2Li4w ODRkYjU3IDEwMDY0NA0KPiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy90NDI0MHFkcy5k dHMNCj4gPiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDQyNDBxZHMuZHRzDQo+ID4gQEAg LTExOCw2ICsxMTgsMTAgQEANCj4gPiAgIAkJfTsNCj4gPg0KPiA+ICAgCQlpMmNAMTE4MDAwIHsN Cj4gPiArCQkJcGNhOTU0N0A3NyB7DQo+ID4gKwkJCQljb21wYXRpYmxlID0gInBoaWxpcHMscGNh OTU0NyI7DQo+ID4gKwkJCQlyZWcgPSA8MHg3Nz47DQo+ID4gKwkJCX07DQo+ID4gICAJCQllZXBy b21ANTEgew0KPiA+ICAgCQkJCWNvbXBhdGlibGUgPSAiYXQyNCwyNGMyNTYiOw0KPiA+ICAgCQkJ CXJlZyA9IDwweDUxPjsNCj4gDQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fDQo+IExpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QNCj4gTGludXhwcGMtZGV2 QGxpc3RzLm96bGFicy5vcmcNCj4gaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xp bnV4cHBjLWRldg0KDQo= ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-04 3:30 ` Tang Yuantian-B29983 @ 2013-09-05 18:40 ` Scott Wood 2013-09-06 2:30 ` Tang Yuantian-B29983 0 siblings, 1 reply; 10+ messages in thread From: Scott Wood @ 2013-09-05 18:40 UTC (permalink / raw) To: Tang Yuantian-B29983 Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org, Yang, Wei, Jia Hongtao-B38951 On Tue, 2013-09-03 at 22:30 -0500, Tang Yuantian-B29983 wrote: > Hi, > > These eeproms are never used by kernel. So no need to add them. The device tree describes the hardware, not what Linux does with it. -Scott ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-05 18:40 ` Scott Wood @ 2013-09-06 2:30 ` Tang Yuantian-B29983 2013-09-06 15:17 ` Scott Wood 0 siblings, 1 reply; 10+ messages in thread From: Tang Yuantian-B29983 @ 2013-09-06 2:30 UTC (permalink / raw) To: Wood Scott-B07421 Cc: linuxppc-dev@lists.ozlabs.org, Yang, Wei, Jia Hongtao-B38951 DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIx DQo+IFNlbnQ6IDIwMTPlubQ55pyINuaXpSDmmJ/mnJ/kupQgMjo0MQ0KPiBUbzogVGFuZyBZdWFu dGlhbi1CMjk5ODMNCj4gQ2M6IFlhbmcsV2VpOyBKaWEgSG9uZ3Rhby1CMzg5NTE7IFdvb2QgU2Nv dHQtQjA3NDIxOyBsaW51eHBwYy0NCj4gZGV2QGxpc3RzLm96bGFicy5vcmcNCj4gU3ViamVjdDog UmU6IFtQQVRDSF0gcG93ZXJwYzogQWRkIEkyQyBidXMgbXVsdGlwbGV4ZXIgbm9kZSBmb3IgQjQg YW5kDQo+IFQ0MjQwUURTDQo+IA0KPiBPbiBUdWUsIDIwMTMtMDktMDMgYXQgMjI6MzAgLTA1MDAs IFRhbmcgWXVhbnRpYW4tQjI5OTgzIHdyb3RlOg0KPiA+IEhpLA0KPiA+DQo+ID4gVGhlc2UgZWVw cm9tcyBhcmUgbmV2ZXIgdXNlZCBieSBrZXJuZWwuIFNvIG5vIG5lZWQgdG8gYWRkIHRoZW0uDQo+ IA0KPiBUaGUgZGV2aWNlIHRyZWUgZGVzY3JpYmVzIHRoZSBoYXJkd2FyZSwgbm90IHdoYXQgTGlu dXggZG9lcyB3aXRoIGl0Lg0KPiANCk1pc3Npbmcgc29tZSBub2RlcyBkb2Vzbid0IG1lYW4gaXQg aXMgbm90IGRlc2NyaWJpbmcgdGhlIGhhcmR3YXJlLg0KVGhlcmUgYXJlIGFsbW9zdCBmaWZ0eSBJ MkMgZGV2aWNlcyBvbiBUNCBjb25uZWN0ZWQgdG8gUENBOTU0Ny4NCkRvIHlvdSB0aGluayB3ZSBu ZWVkIHRvIGxpc3QgdGhlbSBhbGw/DQoNClJlZ2FyZHMsDQpZdWFudGlhbg0KDQo+IC1TY290dA0K PiANCg0K ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-06 2:30 ` Tang Yuantian-B29983 @ 2013-09-06 15:17 ` Scott Wood 0 siblings, 0 replies; 10+ messages in thread From: Scott Wood @ 2013-09-06 15:17 UTC (permalink / raw) To: Tang Yuantian-B29983 Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org, Yang, Wei, Jia Hongtao-B38951 On Thu, 2013-09-05 at 21:30 -0500, Tang Yuantian-B29983 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: 2013=E5=B9=B49=E6=9C=886=E6=97=A5 =E6=98=9F=E6=9C=9F=E4=BA=94 2= :41 > > To: Tang Yuantian-B29983 > > Cc: Yang,Wei; Jia Hongtao-B38951; Wood Scott-B07421; linuxppc- > > dev@lists.ozlabs.org > > Subject: Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and > > T4240QDS > >=20 > > On Tue, 2013-09-03 at 22:30 -0500, Tang Yuantian-B29983 wrote: > > > Hi, > > > > > > These eeproms are never used by kernel. So no need to add them. > >=20 > > The device tree describes the hardware, not what Linux does with it. > >=20 > Missing some nodes doesn't mean it is not describing the hardware. > There are almost fifty I2C devices on T4 connected to PCA9547. > Do you think we need to list them all? Ideally, yes. I realize it's not uncommon for some things to be missing, but that's not a reason to tell people to leave things out just because Linux doesn't use them. -Scott ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-04 1:27 ` Yang,Wei 2013-09-04 3:30 ` Tang Yuantian-B29983 @ 2013-09-04 3:37 ` Jia Hongtao-B38951 2013-09-04 4:03 ` Tang Yuantian-B29983 1 sibling, 1 reply; 10+ messages in thread From: Jia Hongtao-B38951 @ 2013-09-04 3:37 UTC (permalink / raw) To: Yang,Wei; +Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org Hi Wei, I totally agree that the i2c nodes topology should end up like you said. But I think adding sub-nodes should step by step. Actually the hardware i2c topology are huge like on T4. So I'd like to adding nodes when we needed. If you think the sub-nodes are needed please send another patch based on mi= ne. I think this is the more reasonable way. Thanks. -Hongtao > -----Original Message----- > From: Yang,Wei [mailto:Wei.Yang@windriver.com] > Sent: Wednesday, September 04, 2013 9:27 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Jia Hongtao-B38951 > Subject: Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and > T4240QDS >=20 > On 09/03/2013 03:51 PM, Jia Hongtao wrote: > > In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used. >=20 > Hi Hongtao, >=20 > If you want to support I2C bus multiplexer, for T4 and B4QDS platform, > since some eeprom devices is connected to PCA9574 I2C bus multiplexer, so > these devices should be connected to pca9547 node. Just like the > following, what do you think of it? >=20 > + pca9547@77 { > + compatible =3D "philips,pca9547"; > + reg =3D <0x77>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + channel@0 { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + reg =3D <0>; > + eeprom@51 { > + compatible =3D > "at24,24c256"; > + reg =3D <0x51>; > + }; > + eeprom@52 { > + compatible =3D > "at24,24c256"; > + reg =3D <0x52>; > + }; > + eeprom@53 { > + compatible =3D > "at24,24c256"; > + reg =3D <0x53>; > + }; > + eeprom@54 { > + compatible =3D > "at24,24c256"; > + reg =3D <0x54>; > + }; > + eeprom@55 { > + compatible =3D > "at24,24c256"; > + reg =3D <0x55>; > + }; > + eeprom@56 { > + compatible =3D > "at24,24c256"; > + reg =3D <0x56>; > + }; > + rtc@68 { > + compatible =3D > "dallas,ds3232"; > + reg =3D <0x68>; > + interrupts =3D > <0x1 0x1 0 0>; > + }; > + }; >=20 > Wei > > > > Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com> > > --- > > arch/powerpc/boot/dts/b4qds.dtsi | 4 ++++ > > arch/powerpc/boot/dts/t4240qds.dts | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/arch/powerpc/boot/dts/b4qds.dtsi > > b/arch/powerpc/boot/dts/b4qds.dtsi > > index e6d2f8f..2aa3399 100644 > > --- a/arch/powerpc/boot/dts/b4qds.dtsi > > +++ b/arch/powerpc/boot/dts/b4qds.dtsi > > @@ -120,6 +120,10 @@ > > }; > > > > i2c@118000 { > > + pca9547@77 { > > + compatible =3D "philips,pca9547"; > > + reg =3D <0x77>; > > + }; > > eeprom@50 { > > compatible =3D "at24,24c64"; > > reg =3D <0x50>; > > diff --git a/arch/powerpc/boot/dts/t4240qds.dts > > b/arch/powerpc/boot/dts/t4240qds.dts > > index 0555976..084db57 100644 > > --- a/arch/powerpc/boot/dts/t4240qds.dts > > +++ b/arch/powerpc/boot/dts/t4240qds.dts > > @@ -118,6 +118,10 @@ > > }; > > > > i2c@118000 { > > + pca9547@77 { > > + compatible =3D "philips,pca9547"; > > + reg =3D <0x77>; > > + }; > > eeprom@51 { > > compatible =3D "at24,24c256"; > > reg =3D <0x51>; >=20 ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-04 3:37 ` Jia Hongtao-B38951 @ 2013-09-04 4:03 ` Tang Yuantian-B29983 2013-09-04 4:10 ` Jia Hongtao-B38951 2013-09-04 4:27 ` Yang,Wei 0 siblings, 2 replies; 10+ messages in thread From: Tang Yuantian-B29983 @ 2013-09-04 4:03 UTC (permalink / raw) To: Jia Hongtao-B38951, Yang,Wei Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org SGksDQpJIG5vdGljZWQgdGhhdCB0aGVyZSBhcmUgYWxyZWFkeSBzb21lIG5vZGVzIGluIGkyYyBi dXMuDQpZb3Ugc2hvdWxkIGF0IGxlYXN0IG1vdmUgdGhlIGV4aXN0aW5nIG5vZGUgaW50byBQQ0E5 NTQ3Lg0KDQpUaGFua3MsDQpZdWFudGlhbg0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0t LS0NCj4gRnJvbTogTGludXhwcGMtZGV2IFttYWlsdG86bGludXhwcGMtZGV2LQ0KPiBib3VuY2Vz K2IyOTk4Mz1mcmVlc2NhbGUuY29tQGxpc3RzLm96bGFicy5vcmddIE9uIEJlaGFsZiBPZiBKaWEg SG9uZ3Rhby0NCj4gQjM4OTUxDQo+IFNlbnQ6IDIwMTPE6jnUwjTI1SDQx8bayP0gMTE6MzgNCj4g VG86IFlhbmcsV2VpDQo+IENjOiBXb29kIFNjb3R0LUIwNzQyMTsgbGludXhwcGMtZGV2QGxpc3Rz Lm96bGFicy5vcmcNCj4gU3ViamVjdDogUkU6IFtQQVRDSF0gcG93ZXJwYzogQWRkIEkyQyBidXMg bXVsdGlwbGV4ZXIgbm9kZSBmb3IgQjQgYW5kDQo+IFQ0MjQwUURTDQo+IA0KPiBIaSBXZWksDQo+ IA0KPiBJIHRvdGFsbHkgYWdyZWUgdGhhdCB0aGUgaTJjIG5vZGVzIHRvcG9sb2d5IHNob3VsZCBl bmQgdXAgbGlrZSB5b3Ugc2FpZC4NCj4gDQo+IEJ1dCBJIHRoaW5rIGFkZGluZyBzdWItbm9kZXMg c2hvdWxkIHN0ZXAgYnkgc3RlcC4NCj4gQWN0dWFsbHkgdGhlIGhhcmR3YXJlIGkyYyB0b3BvbG9n eSBhcmUgaHVnZSBsaWtlIG9uIFQ0Lg0KPiBTbyBJJ2QgbGlrZSB0byBhZGRpbmcgbm9kZXMgd2hl biB3ZSBuZWVkZWQuDQo+IElmIHlvdSB0aGluayB0aGUgc3ViLW5vZGVzIGFyZSBuZWVkZWQgcGxl YXNlIHNlbmQgYW5vdGhlciBwYXRjaCBiYXNlZCBvbg0KPiBtaW5lLg0KPiBJIHRoaW5rIHRoaXMg aXMgdGhlIG1vcmUgcmVhc29uYWJsZSB3YXkuDQo+IA0KPiBUaGFua3MuDQo+IA0KPiAtSG9uZ3Rh bw0KPiANCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBZYW5n LFdlaSBbbWFpbHRvOldlaS5ZYW5nQHdpbmRyaXZlci5jb21dDQo+ID4gU2VudDogV2VkbmVzZGF5 LCBTZXB0ZW1iZXIgMDQsIDIwMTMgOToyNyBBTQ0KPiA+IFRvOiBKaWEgSG9uZ3Rhby1CMzg5NTEN Cj4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IFdvb2QgU2NvdHQtQjA3NDIx OyBKaWENCj4gPiBIb25ndGFvLUIzODk1MQ0KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2Vy cGM6IEFkZCBJMkMgYnVzIG11bHRpcGxleGVyIG5vZGUgZm9yIEI0IGFuZA0KPiA+IFQ0MjQwUURT DQo+ID4NCj4gPiBPbiAwOS8wMy8yMDEzIDAzOjUxIFBNLCBKaWEgSG9uZ3RhbyB3cm90ZToNCj4g PiA+IEluIGJvdGggQjQgYW5kIFQ0MjQwUURTIHBsYXRmb3JtIFBDQTk1NDcgSTJDIGJ1cyBtdWx0 aXBsZXhlciBpcyB1c2VkLg0KPiA+DQo+ID4gSGkgSG9uZ3RhbywNCj4gPg0KPiA+IElmIHlvdSB3 YW50IHRvIHN1cHBvcnQgSTJDIGJ1cyBtdWx0aXBsZXhlciwgZm9yIFQ0IGFuZCBCNFFEUyBwbGF0 Zm9ybSwNCj4gPiBzaW5jZSBzb21lIGVlcHJvbSBkZXZpY2VzIGlzIGNvbm5lY3RlZCB0byBQQ0E5 NTc0IEkyQyBidXMgbXVsdGlwbGV4ZXIsDQo+ID4gc28gdGhlc2UgZGV2aWNlcyBzaG91bGQgYmUg Y29ubmVjdGVkIHRvIHBjYTk1NDcgbm9kZS4gSnVzdCBsaWtlIHRoZQ0KPiA+IGZvbGxvd2luZywg d2hhdCBkbyB5b3UgdGhpbmsgb2YgaXQ/DQo+ID4NCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICBwY2E5NTQ3QDc3IHsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBh dGlibGUgPSAicGhpbGlwcyxwY2E5NTQ3IjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHJlZyA9IDwweDc3PjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICNhZGRyZXNzLWNlbGxzID0gPDE+Ow0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgI3NpemUtY2VsbHMgPSA8MD47DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjaGFubmVsQDAgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47DQo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJlZyA9IDwwPjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTEgew0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9DQo+ ID4gImF0MjQsMjRjMjU2IjsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDUxPjsNCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVlcHJvbUA1MiB7DQo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxl ID0NCj4gPiAiYXQyNCwyNGMyNTYiOw0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4NTI+Ow0KPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZWVwcm9tQDUzIHsNCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBh dGlibGUgPQ0KPiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHg1Mz47DQo+ID4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsNCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTQgew0KPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29tcGF0aWJsZSA9DQo+ID4gImF0MjQsMjRjMjU2IjsNCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDU0PjsNCj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVlcHJvbUA1NSB7 DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjb21wYXRpYmxlID0NCj4gPiAiYXQyNCwyNGMyNTYiOw0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDB4NTU+Ow0K PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZWVwcm9t QDU2IHsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbXBhdGlibGUgPQ0KPiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHg1 Nj47DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fTsNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy dGNANjggew0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29tcGF0aWJsZSA9DQo+ID4gImRhbGxhcyxkczMyMzIiOw0KPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0g PDB4Njg+Ow0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW50ZXJydXB0cyA9DQo+ID4gPDB4MSAweDEgMCAwPjsNCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9Ow0KPiA+DQo+ID4gV2VpDQo+ID4gPg0K PiA+ID4gU2lnbmVkLW9mZi1ieTogSmlhIEhvbmd0YW8gPGhvbmd0YW8uamlhQGZyZWVzY2FsZS5j b20+DQo+ID4gPiAtLS0NCj4gPiA+ICAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2I0cWRzLmR0c2kg ICB8IDQgKysrKw0KPiA+ID4gICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDQyNDBxZHMuZHRzIHwg NCArKysrDQo+ID4gPiAgIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspDQo+ID4gPg0K PiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNpDQo+ID4g PiBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNpDQo+ID4gPiBpbmRleCBlNmQyZjhm Li4yYWEzMzk5IDEwMDY0NA0KPiA+ID4gLS0tIGEvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL2I0cWRz LmR0c2kNCj4gPiA+ICsrKyBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNpDQo+ID4g PiBAQCAtMTIwLDYgKzEyMCwxMCBAQA0KPiA+ID4gICAJCX07DQo+ID4gPg0KPiA+ID4gICAJCWky Y0AxMTgwMDAgew0KPiA+ID4gKwkJCXBjYTk1NDdANzcgew0KPiA+ID4gKwkJCQljb21wYXRpYmxl ID0gInBoaWxpcHMscGNhOTU0NyI7DQo+ID4gPiArCQkJCXJlZyA9IDwweDc3PjsNCj4gPiA+ICsJ CQl9Ow0KPiA+ID4gICAJCQllZXByb21ANTAgew0KPiA+ID4gICAJCQkJY29tcGF0aWJsZSA9ICJh dDI0LDI0YzY0IjsNCj4gPiA+ICAgCQkJCXJlZyA9IDwweDUwPjsNCj4gPiA+IGRpZmYgLS1naXQg YS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDQyNDBxZHMuZHRzDQo+ID4gPiBiL2FyY2gvcG93ZXJw Yy9ib290L2R0cy90NDI0MHFkcy5kdHMNCj4gPiA+IGluZGV4IDA1NTU5NzYuLjA4NGRiNTcgMTAw NjQ0DQo+ID4gPiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDQyNDBxZHMuZHRzDQo+ID4g PiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDQyNDBxZHMuZHRzDQo+ID4gPiBAQCAtMTE4 LDYgKzExOCwxMCBAQA0KPiA+ID4gICAJCX07DQo+ID4gPg0KPiA+ID4gICAJCWkyY0AxMTgwMDAg ew0KPiA+ID4gKwkJCXBjYTk1NDdANzcgew0KPiA+ID4gKwkJCQljb21wYXRpYmxlID0gInBoaWxp cHMscGNhOTU0NyI7DQo+ID4gPiArCQkJCXJlZyA9IDwweDc3PjsNCj4gPiA+ICsJCQl9Ow0KPiA+ ID4gICAJCQllZXByb21ANTEgew0KPiA+ID4gICAJCQkJY29tcGF0aWJsZSA9ICJhdDI0LDI0YzI1 NiI7DQo+ID4gPiAgIAkJCQlyZWcgPSA8MHg1MT47DQo+ID4NCj4gDQo+IA0KPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPiBMaW51eHBwYy1kZXYgbWFp bGluZyBsaXN0DQo+IExpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IGh0dHBzOi8vbGlz dHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXYNCg0K ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-04 4:03 ` Tang Yuantian-B29983 @ 2013-09-04 4:10 ` Jia Hongtao-B38951 2013-09-04 4:27 ` Yang,Wei 1 sibling, 0 replies; 10+ messages in thread From: Jia Hongtao-B38951 @ 2013-09-04 4:10 UTC (permalink / raw) To: Tang Yuantian-B29983, Yang,Wei Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org SGkgWXVhbnRpYW4sDQpZZXMsIHlvdSBhcmUgcmlnaHQuDQoNCkhpIFdlaSwNCkkgbWlzdW5kZXJz dG9vZCB5b3VyIGlkZWEuDQpJIGFncmVlIGl0IGFuZCBJIHdpbGwgc3VibWl0IFYyIHBhdGNoIHRv IHVwZGF0ZSBpdCBzb29uLg0KDQpUaGFua3MuDQotSG9uZ3Rhbw0KDQo+IC0tLS0tT3JpZ2luYWwg TWVzc2FnZS0tLS0tDQo+IEZyb206IFRhbmcgWXVhbnRpYW4tQjI5OTgzDQo+IFNlbnQ6IFdlZG5l c2RheSwgU2VwdGVtYmVyIDA0LCAyMDEzIDEyOjA0IFBNDQo+IFRvOiBKaWEgSG9uZ3Rhby1CMzg5 NTE7IFlhbmcsV2VpDQo+IENjOiBXb29kIFNjb3R0LUIwNzQyMTsgbGludXhwcGMtZGV2QGxpc3Rz Lm96bGFicy5vcmcNCj4gU3ViamVjdDogUkU6IFtQQVRDSF0gcG93ZXJwYzogQWRkIEkyQyBidXMg bXVsdGlwbGV4ZXIgbm9kZSBmb3IgQjQgYW5kDQo+IFQ0MjQwUURTDQo+IA0KPiBIaSwNCj4gSSBu b3RpY2VkIHRoYXQgdGhlcmUgYXJlIGFscmVhZHkgc29tZSBub2RlcyBpbiBpMmMgYnVzLg0KPiBZ b3Ugc2hvdWxkIGF0IGxlYXN0IG1vdmUgdGhlIGV4aXN0aW5nIG5vZGUgaW50byBQQ0E5NTQ3Lg0K PiANCj4gVGhhbmtzLA0KPiBZdWFudGlhbg0KPiANCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0NCj4gPiBGcm9tOiBMaW51eHBwYy1kZXYgW21haWx0bzpsaW51eHBwYy1kZXYtDQo+ ID4gYm91bmNlcytiMjk5ODM9ZnJlZXNjYWxlLmNvbUBsaXN0cy5vemxhYnMub3JnXSBPbiBCZWhh bGYgT2YgSmlhDQo+ID4gYm91bmNlcytIb25ndGFvLQ0KPiA+IEIzODk1MQ0KPiA+IFNlbnQ6IDIw MTPE6jnUwjTI1SDQx8bayP0gMTE6MzgNCj4gPiBUbzogWWFuZyxXZWkNCj4gPiBDYzogV29vZCBT Y290dC1CMDc0MjE7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+ID4gU3ViamVjdDog UkU6IFtQQVRDSF0gcG93ZXJwYzogQWRkIEkyQyBidXMgbXVsdGlwbGV4ZXIgbm9kZSBmb3IgQjQg YW5kDQo+ID4gVDQyNDBRRFMNCj4gPg0KPiA+IEhpIFdlaSwNCj4gPg0KPiA+IEkgdG90YWxseSBh Z3JlZSB0aGF0IHRoZSBpMmMgbm9kZXMgdG9wb2xvZ3kgc2hvdWxkIGVuZCB1cCBsaWtlIHlvdSBz YWlkLg0KPiA+DQo+ID4gQnV0IEkgdGhpbmsgYWRkaW5nIHN1Yi1ub2RlcyBzaG91bGQgc3RlcCBi eSBzdGVwLg0KPiA+IEFjdHVhbGx5IHRoZSBoYXJkd2FyZSBpMmMgdG9wb2xvZ3kgYXJlIGh1Z2Ug bGlrZSBvbiBUNC4NCj4gPiBTbyBJJ2QgbGlrZSB0byBhZGRpbmcgbm9kZXMgd2hlbiB3ZSBuZWVk ZWQuDQo+ID4gSWYgeW91IHRoaW5rIHRoZSBzdWItbm9kZXMgYXJlIG5lZWRlZCBwbGVhc2Ugc2Vu ZCBhbm90aGVyIHBhdGNoIGJhc2VkDQo+ID4gb24gbWluZS4NCj4gPiBJIHRoaW5rIHRoaXMgaXMg dGhlIG1vcmUgcmVhc29uYWJsZSB3YXkuDQo+ID4NCj4gPiBUaGFua3MuDQo+ID4NCj4gPiAtSG9u Z3Rhbw0KPiA+DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBG cm9tOiBZYW5nLFdlaSBbbWFpbHRvOldlaS5ZYW5nQHdpbmRyaXZlci5jb21dDQo+ID4gPiBTZW50 OiBXZWRuZXNkYXksIFNlcHRlbWJlciAwNCwgMjAxMyA5OjI3IEFNDQo+ID4gPiBUbzogSmlhIEhv bmd0YW8tQjM4OTUxDQo+ID4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IFdv b2QgU2NvdHQtQjA3NDIxOyBKaWENCj4gPiA+IEhvbmd0YW8tQjM4OTUxDQo+ID4gPiBTdWJqZWN0 OiBSZTogW1BBVENIXSBwb3dlcnBjOiBBZGQgSTJDIGJ1cyBtdWx0aXBsZXhlciBub2RlIGZvciBC NA0KPiA+ID4gYW5kIFQ0MjQwUURTDQo+ID4gPg0KPiA+ID4gT24gMDkvMDMvMjAxMyAwMzo1MSBQ TSwgSmlhIEhvbmd0YW8gd3JvdGU6DQo+ID4gPiA+IEluIGJvdGggQjQgYW5kIFQ0MjQwUURTIHBs YXRmb3JtIFBDQTk1NDcgSTJDIGJ1cyBtdWx0aXBsZXhlciBpcw0KPiB1c2VkLg0KPiA+ID4NCj4g PiA+IEhpIEhvbmd0YW8sDQo+ID4gPg0KPiA+ID4gSWYgeW91IHdhbnQgdG8gc3VwcG9ydCBJMkMg YnVzIG11bHRpcGxleGVyLCBmb3IgVDQgYW5kIEI0UURTDQo+ID4gPiBwbGF0Zm9ybSwgc2luY2Ug c29tZSBlZXByb20gZGV2aWNlcyBpcyBjb25uZWN0ZWQgdG8gUENBOTU3NCBJMkMgYnVzDQo+ID4g PiBtdWx0aXBsZXhlciwgc28gdGhlc2UgZGV2aWNlcyBzaG91bGQgYmUgY29ubmVjdGVkIHRvIHBj YTk1NDcgbm9kZS4NCj4gPiA+IEp1c3QgbGlrZSB0aGUgZm9sbG93aW5nLCB3aGF0IGRvIHlvdSB0 aGluayBvZiBpdD8NCj4gPiA+DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBwY2E5NTQ3 QDc3IHsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9 ICJwaGlsaXBzLHBjYTk1NDciOw0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICByZWcgPSA8MHg3Nz47DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICNh ZGRyZXNzLWNlbGxzID0gPDE+Ow0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAjc2l6ZS1jZWxscyA9IDwwPjsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY2hhbm5lbEAwIHsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsNCj4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MD47DQo+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTEgew0KPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21w YXRpYmxlID0NCj4gPiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDUxPjsNCj4gPiA+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ID4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21A NTIgew0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb21wYXRpYmxlID0NCj4gPiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9 IDwweDUyPjsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIH07DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBlZXByb21ANTMgew0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0NCj4gPiA+ICJhdDI0LDI0YzI1 NiI7DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJlZyA9IDwweDUzPjsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIH07DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTQgew0KPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0NCj4g PiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDU0PjsNCj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZXByb21ANTUgew0KPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b21wYXRpYmxlID0NCj4gPiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDU1PjsNCj4g PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH07DQo+ ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlZXBy b21ANTYgew0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBjb21wYXRpYmxlID0NCj4gPiA+ICJhdDI0LDI0YzI1NiI7DQo+ID4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJl ZyA9IDwweDU2PjsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIH07DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBydGNANjggew0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0NCj4gPiA+ICJkYWxsYXMsZHMz MjMyIjsNCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcmVnID0gPDB4Njg+Ow0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnJ1cHRzID0NCj4gPiA+IDwweDEg MHgxIDAgMD47DQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB9Ow0KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IH07DQo+ID4gPg0KPiA+ID4gV2VpDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEpp YSBIb25ndGFvIDxob25ndGFvLmppYUBmcmVlc2NhbGUuY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+ ID4gICBhcmNoL3Bvd2VycGMvYm9vdC9kdHMvYjRxZHMuZHRzaSAgIHwgNCArKysrDQo+ID4gPiA+ ICAgYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3Q0MjQwcWRzLmR0cyB8IDQgKysrKw0KPiA+ID4gPiAg IDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspDQo+ID4gPiA+DQo+ID4gPiA+IGRpZmYg LS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvYjRxZHMuZHRzaQ0KPiA+ID4gPiBiL2FyY2gv cG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNpDQo+ID4gPiA+IGluZGV4IGU2ZDJmOGYuLjJhYTMz OTkgMTAwNjQ0DQo+ID4gPiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNp DQo+ID4gPiA+ICsrKyBiL2FyY2gvcG93ZXJwYy9ib290L2R0cy9iNHFkcy5kdHNpDQo+ID4gPiA+ IEBAIC0xMjAsNiArMTIwLDEwIEBADQo+ID4gPiA+ICAgCQl9Ow0KPiA+ID4gPg0KPiA+ID4gPiAg IAkJaTJjQDExODAwMCB7DQo+ID4gPiA+ICsJCQlwY2E5NTQ3QDc3IHsNCj4gPiA+ID4gKwkJCQlj b21wYXRpYmxlID0gInBoaWxpcHMscGNhOTU0NyI7DQo+ID4gPiA+ICsJCQkJcmVnID0gPDB4Nzc+ Ow0KPiA+ID4gPiArCQkJfTsNCj4gPiA+ID4gICAJCQllZXByb21ANTAgew0KPiA+ID4gPiAgIAkJ CQljb21wYXRpYmxlID0gImF0MjQsMjRjNjQiOw0KPiA+ID4gPiAgIAkJCQlyZWcgPSA8MHg1MD47 DQo+ID4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvdDQyNDBxZHMuZHRz DQo+ID4gPiA+IGIvYXJjaC9wb3dlcnBjL2Jvb3QvZHRzL3Q0MjQwcWRzLmR0cw0KPiA+ID4gPiBp bmRleCAwNTU1OTc2Li4wODRkYjU3IDEwMDY0NA0KPiA+ID4gPiAtLS0gYS9hcmNoL3Bvd2VycGMv Ym9vdC9kdHMvdDQyNDBxZHMuZHRzDQo+ID4gPiA+ICsrKyBiL2FyY2gvcG93ZXJwYy9ib290L2R0 cy90NDI0MHFkcy5kdHMNCj4gPiA+ID4gQEAgLTExOCw2ICsxMTgsMTAgQEANCj4gPiA+ID4gICAJ CX07DQo+ID4gPiA+DQo+ID4gPiA+ICAgCQlpMmNAMTE4MDAwIHsNCj4gPiA+ID4gKwkJCXBjYTk1 NDdANzcgew0KPiA+ID4gPiArCQkJCWNvbXBhdGlibGUgPSAicGhpbGlwcyxwY2E5NTQ3IjsNCj4g PiA+ID4gKwkJCQlyZWcgPSA8MHg3Nz47DQo+ID4gPiA+ICsJCQl9Ow0KPiA+ID4gPiAgIAkJCWVl cHJvbUA1MSB7DQo+ID4gPiA+ICAgCQkJCWNvbXBhdGlibGUgPSAiYXQyNCwyNGMyNTYiOw0KPiA+ ID4gPiAgIAkJCQlyZWcgPSA8MHg1MT47DQo+ID4gPg0KPiA+DQo+ID4NCj4gPiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KPiA+IExpbnV4cHBjLWRldiBt YWlsaW5nIGxpc3QNCj4gPiBMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiA+IGh0dHBz Oi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXYNCg0K ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS 2013-09-04 4:03 ` Tang Yuantian-B29983 2013-09-04 4:10 ` Jia Hongtao-B38951 @ 2013-09-04 4:27 ` Yang,Wei 1 sibling, 0 replies; 10+ messages in thread From: Yang,Wei @ 2013-09-04 4:27 UTC (permalink / raw) To: Tang Yuantian-B29983 Cc: Wood Scott-B07421, linuxppc-dev@lists.ozlabs.org, Jia Hongtao-B38951 On 09/04/2013 12:03 PM, Tang Yuantian-B29983 wrote: > Hi, > I noticed that there are already some nodes in i2c bus. Sorry for my late response, yeah, just as you noticed, some eeprom nodes already are inside i2c bus.:-) Wei > You should at least move the existing node into PCA9547. > > Thanks, > Yuantian > > >> -----Original Message----- >> From: Linuxppc-dev [mailto:linuxppc-dev- >> bounces+b29983=freescale.com@lists.ozlabs.org] On Behalf Of Jia Hongtao- >> B38951 >> Sent: 2013年9月4日 星期三 11:38 >> To: Yang,Wei >> Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org >> Subject: RE: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and >> T4240QDS >> >> Hi Wei, >> >> I totally agree that the i2c nodes topology should end up like you said. >> >> But I think adding sub-nodes should step by step. >> Actually the hardware i2c topology are huge like on T4. >> So I'd like to adding nodes when we needed. >> If you think the sub-nodes are needed please send another patch based on >> mine. >> I think this is the more reasonable way. >> >> Thanks. >> >> -Hongtao >> >> >>> -----Original Message----- >>> From: Yang,Wei [mailto:Wei.Yang@windriver.com] >>> Sent: Wednesday, September 04, 2013 9:27 AM >>> To: Jia Hongtao-B38951 >>> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Jia >>> Hongtao-B38951 >>> Subject: Re: [PATCH] powerpc: Add I2C bus multiplexer node for B4 and >>> T4240QDS >>> >>> On 09/03/2013 03:51 PM, Jia Hongtao wrote: >>>> In both B4 and T4240QDS platform PCA9547 I2C bus multiplexer is used. >>> Hi Hongtao, >>> >>> If you want to support I2C bus multiplexer, for T4 and B4QDS platform, >>> since some eeprom devices is connected to PCA9574 I2C bus multiplexer, >>> so these devices should be connected to pca9547 node. Just like the >>> following, what do you think of it? >>> >>> + pca9547@77 { >>> + compatible = "philips,pca9547"; >>> + reg = <0x77>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + channel@0 { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + reg = <0>; >>> + eeprom@51 { >>> + compatible = >>> "at24,24c256"; >>> + reg = <0x51>; >>> + }; >>> + eeprom@52 { >>> + compatible = >>> "at24,24c256"; >>> + reg = <0x52>; >>> + }; >>> + eeprom@53 { >>> + compatible = >>> "at24,24c256"; >>> + reg = <0x53>; >>> + }; >>> + eeprom@54 { >>> + compatible = >>> "at24,24c256"; >>> + reg = <0x54>; >>> + }; >>> + eeprom@55 { >>> + compatible = >>> "at24,24c256"; >>> + reg = <0x55>; >>> + }; >>> + eeprom@56 { >>> + compatible = >>> "at24,24c256"; >>> + reg = <0x56>; >>> + }; >>> + rtc@68 { >>> + compatible = >>> "dallas,ds3232"; >>> + reg = <0x68>; >>> + interrupts = >>> <0x1 0x1 0 0>; >>> + }; >>> + }; >>> >>> Wei >>>> Signed-off-by: Jia Hongtao <hongtao.jia@freescale.com> >>>> --- >>>> arch/powerpc/boot/dts/b4qds.dtsi | 4 ++++ >>>> arch/powerpc/boot/dts/t4240qds.dts | 4 ++++ >>>> 2 files changed, 8 insertions(+) >>>> >>>> diff --git a/arch/powerpc/boot/dts/b4qds.dtsi >>>> b/arch/powerpc/boot/dts/b4qds.dtsi >>>> index e6d2f8f..2aa3399 100644 >>>> --- a/arch/powerpc/boot/dts/b4qds.dtsi >>>> +++ b/arch/powerpc/boot/dts/b4qds.dtsi >>>> @@ -120,6 +120,10 @@ >>>> }; >>>> >>>> i2c@118000 { >>>> + pca9547@77 { >>>> + compatible = "philips,pca9547"; >>>> + reg = <0x77>; >>>> + }; >>>> eeprom@50 { >>>> compatible = "at24,24c64"; >>>> reg = <0x50>; >>>> diff --git a/arch/powerpc/boot/dts/t4240qds.dts >>>> b/arch/powerpc/boot/dts/t4240qds.dts >>>> index 0555976..084db57 100644 >>>> --- a/arch/powerpc/boot/dts/t4240qds.dts >>>> +++ b/arch/powerpc/boot/dts/t4240qds.dts >>>> @@ -118,6 +118,10 @@ >>>> }; >>>> >>>> i2c@118000 { >>>> + pca9547@77 { >>>> + compatible = "philips,pca9547"; >>>> + reg = <0x77>; >>>> + }; >>>> eeprom@51 { >>>> compatible = "at24,24c256"; >>>> reg = <0x51>; >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-09-06 15:17 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-03 7:51 [PATCH] powerpc: Add I2C bus multiplexer node for B4 and T4240QDS Jia Hongtao 2013-09-04 1:27 ` Yang,Wei 2013-09-04 3:30 ` Tang Yuantian-B29983 2013-09-05 18:40 ` Scott Wood 2013-09-06 2:30 ` Tang Yuantian-B29983 2013-09-06 15:17 ` Scott Wood 2013-09-04 3:37 ` Jia Hongtao-B38951 2013-09-04 4:03 ` Tang Yuantian-B29983 2013-09-04 4:10 ` Jia Hongtao-B38951 2013-09-04 4:27 ` Yang,Wei
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).