* powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) @ 2013-09-09 0:28 Guenter Roeck 2013-09-09 23:55 ` Asai Thambi S P 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2013-09-09 0:28 UTC (permalink / raw) To: linux-kernel@vger.kernel.org Cc: Vasant Hegde, Shivaprasad G Bhat, linuxppc-dev, Paul Mackerras Hi all, powerpc allmodconfig build on the latest upstream kernel results in: ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace). Not surprising, as cpu_to_chip_id() is not exported. Reverting this commit fixes the problem. Any good idea how to fix it for real ? Guenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) 2013-09-09 0:28 powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) Guenter Roeck @ 2013-09-09 23:55 ` Asai Thambi S P 2013-09-10 1:18 ` Guenter Roeck 2013-09-10 22:02 ` Benjamin Herrenschmidt 0 siblings, 2 replies; 6+ messages in thread From: Asai Thambi S P @ 2013-09-09 23:55 UTC (permalink / raw) To: Vasant Hegde, Shivaprasad G Bhat Cc: Paul Mackerras, linuxppc-dev, linux-kernel@vger.kernel.org, Guenter Roeck On 09/08/2013 5:28 PM, Guenter Roeck wrote: > Hi all, > > powerpc allmodconfig build on the latest upstream kernel results in: > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > This is due to commit 15863ff3b (powerpc: Make chip-id information > available to userspace). > Not surprising, as cpu_to_chip_id() is not exported. > Apart from the above error, I have a concern on the patch, purely based on the commit message. (to be honest, I am not familiar with the ppc architecture) Commit message of 15863ff3b has the following text. ****************** So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" was always default (-1) on ppc64 architecture. Now, some systems have an ibm,chip-id property in the cpu nodes in the device tree. On these systems, we now use this information to display physical_package_id ****************** Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property? > Reverting this commit fixes the problem. Any good idea how to fix it > for real ? > > Guenter > -- > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) 2013-09-09 23:55 ` Asai Thambi S P @ 2013-09-10 1:18 ` Guenter Roeck 2013-09-10 22:02 ` Benjamin Herrenschmidt 1 sibling, 0 replies; 6+ messages in thread From: Guenter Roeck @ 2013-09-10 1:18 UTC (permalink / raw) To: Asai Thambi S P Cc: linux-kernel@vger.kernel.org, Vasant Hegde, Shivaprasad G Bhat, Paul Mackerras, linuxppc-dev On 09/09/2013 04:55 PM, Asai Thambi S P wrote: > On 09/08/2013 5:28 PM, Guenter Roeck wrote: >> Hi all, >> >> powerpc allmodconfig build on the latest upstream kernel results in: >> >> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! >> >> This is due to commit 15863ff3b (powerpc: Make chip-id information available to userspace). >> Not surprising, as cpu_to_chip_id() is not exported. >> > Apart from the above error, I have a concern on the patch, purely based on the commit message. > (to be honest, I am not familiar with the ppc architecture) > > Commit message of 15863ff3b has the following text. > > ****************** > So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" > was always default (-1) on ppc64 architecture. > > Now, some systems have an ibm,chip-id property in the cpu nodes in > the device tree. On these systems, we now use this information to > display physical_package_id > ****************** > > Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property? > Looking into the code, I think that is what it does. For other platforms (ie if there is no ibm,chip-id property) it still returns -1. Question for the fix is what path to take to fix the problem. Exporting cpu_to_chip_id() might be the easiest solution. Other platforms export the respective data, so it should not be a problem. I might submit a patch and see where it goes. Guenter > >> Reverting this commit fixes the problem. Any good idea how to fix it for real ? >> >> Guenter >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) 2013-09-09 23:55 ` Asai Thambi S P 2013-09-10 1:18 ` Guenter Roeck @ 2013-09-10 22:02 ` Benjamin Herrenschmidt 2013-09-10 22:50 ` Guenter Roeck 1 sibling, 1 reply; 6+ messages in thread From: Benjamin Herrenschmidt @ 2013-09-10 22:02 UTC (permalink / raw) To: Asai Thambi S P Cc: linux-kernel@vger.kernel.org, Vasant Hegde, Paul Mackerras, Shivaprasad G Bhat, linuxppc-dev, Guenter Roeck On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote: > On 09/08/2013 5:28 PM, Guenter Roeck wrote: > > Hi all, > > > > powerpc allmodconfig build on the latest upstream kernel results in: > > > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > > > This is due to commit 15863ff3b (powerpc: Make chip-id information > > available to userspace). > > Not surprising, as cpu_to_chip_id() is not exported. > > > Apart from the above error, I have a concern on the patch, purely based on the commit message. > (to be honest, I am not familiar with the ppc architecture) > > Commit message of 15863ff3b has the following text. > > ****************** > So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" > was always default (-1) on ppc64 architecture. > > Now, some systems have an ibm,chip-id property in the cpu nodes in > the device tree. On these systems, we now use this information to > display physical_package_id > ****************** > > Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property? There should be no negative side effect (appart from the missing EXPORT_SYMBOL of course). If the property is not found in the device-tree, the new function returns -1, so it should work fine on all systems. Cheers, Ben. > > > Reverting this commit fixes the problem. Any good idea how to fix it > > for real ? > > > > Guenter > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) 2013-09-10 22:02 ` Benjamin Herrenschmidt @ 2013-09-10 22:50 ` Guenter Roeck 2013-09-11 6:36 ` Vasant Hegde 0 siblings, 1 reply; 6+ messages in thread From: Guenter Roeck @ 2013-09-10 22:50 UTC (permalink / raw) To: Benjamin Herrenschmidt Cc: Asai Thambi S P, linux-kernel@vger.kernel.org, Vasant Hegde, Shivaprasad G Bhat, Paul Mackerras, linuxppc-dev On Wed, Sep 11, 2013 at 08:02:49AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote: > > On 09/08/2013 5:28 PM, Guenter Roeck wrote: > > > Hi all, > > > > > > powerpc allmodconfig build on the latest upstream kernel results in: > > > > > > ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! > > > > > > This is due to commit 15863ff3b (powerpc: Make chip-id information > > > available to userspace). > > > Not surprising, as cpu_to_chip_id() is not exported. > > > > > Apart from the above error, I have a concern on the patch, purely based on the commit message. > > (to be honest, I am not familiar with the ppc architecture) > > > > Commit message of 15863ff3b has the following text. > > > > ****************** > > So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" > > was always default (-1) on ppc64 architecture. > > > > Now, some systems have an ibm,chip-id property in the cpu nodes in > > the device tree. On these systems, we now use this information to > > display physical_package_id > > ****************** > > > > Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property? > > There should be no negative side effect (appart from the missing > EXPORT_SYMBOL of course). If the property is not found in the > device-tree, the new function returns -1, so it should work fine on all > systems. > Good. I submitted a patch doing just that yesterday or so. Hope you'll accept it ;). Thanks, Guenter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) 2013-09-10 22:50 ` Guenter Roeck @ 2013-09-11 6:36 ` Vasant Hegde 0 siblings, 0 replies; 6+ messages in thread From: Vasant Hegde @ 2013-09-11 6:36 UTC (permalink / raw) To: Guenter Roeck Cc: Benjamin Herrenschmidt, Asai Thambi S P, linux-kernel@vger.kernel.org, Shivaprasad G Bhat, Paul Mackerras, linuxppc-dev On 09/11/2013 04:20 AM, Guenter Roeck wrote: > On Wed, Sep 11, 2013 at 08:02:49AM +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2013-09-09 at 16:55 -0700, Asai Thambi S P wrote: >>> On 09/08/2013 5:28 PM, Guenter Roeck wrote: >>>> Hi all, >>>> Guenter, Ben, Sorry for the inconvenience. I never realized my patch could break somewhere :-( Thanks you very much for identifying and fixing this issue. Other patch looks good to me. -Vasant >>>> powerpc allmodconfig build on the latest upstream kernel results in: >>>> >>>> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined! >>>> >>>> This is due to commit 15863ff3b (powerpc: Make chip-id information >>>> available to userspace). >>>> Not surprising, as cpu_to_chip_id() is not exported. >>>> >>> Apart from the above error, I have a concern on the patch, purely based on the commit message. >>> (to be honest, I am not familiar with the ppc architecture) >>> >>> Commit message of 15863ff3b has the following text. >>> >>> ****************** >>> So far "/sys/devices/system/cpu/cpuX/topology/physical_package_id" >>> was always default (-1) on ppc64 architecture. >>> >>> Now, some systems have an ibm,chip-id property in the cpu nodes in >>> the device tree. On these systems, we now use this information to >>> display physical_package_id >>> ****************** >>> >>> Shouldn't the new definition of "topology_physical_package_id" apply only to those systems supporting ibm,chip-id property? >> >> There should be no negative side effect (appart from the missing >> EXPORT_SYMBOL of course). If the property is not found in the >> device-tree, the new function returns -1, so it should work fine on all >> systems. >> > Good. I submitted a patch doing just that yesterday or so. > Hope you'll accept it ;). > > Thanks, > Guenter > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-11 6:36 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-09 0:28 powerpc allmodconfig build broken due to commit 15863ff3b (powerpc: Make chip-id information available to userspace) Guenter Roeck 2013-09-09 23:55 ` Asai Thambi S P 2013-09-10 1:18 ` Guenter Roeck 2013-09-10 22:02 ` Benjamin Herrenschmidt 2013-09-10 22:50 ` Guenter Roeck 2013-09-11 6:36 ` Vasant Hegde
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).