From: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] powerpc: Export cpu_to_chip_id() to fix build error
Date: Wed, 11 Sep 2013 13:30:30 +0530 [thread overview]
Message-ID: <5230231E.8070104@linux.vnet.ibm.com> (raw)
In-Reply-To: <1378850610.4121.29.camel@pasglop>
On 09/11/2013 03:33 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2013-09-09 at 18:37 -0700, Guenter Roeck wrote:
>> powerpc allmodconfig build fails with:
>>
>> ERROR: ".cpu_to_chip_id" [drivers/block/mtip32xx/mtip32xx.ko] undefined!
>>
>> The problem was introduced with commit 15863ff3b (powerpc: Make chip-id
>> information available to userspace).
>
> Thanks, I'll send that to Linus asap.
>
Verified on today's Linus tree. This issue is fixed.
Thanks a lot.
-Vasant
> Ben.
>
>> Export the missing symbol.
>>
>> Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
>> Cc: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> arch/powerpc/kernel/smp.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
>> index 442d8e2..8e59abc 100644
>> --- a/arch/powerpc/kernel/smp.c
>> +++ b/arch/powerpc/kernel/smp.c
>> @@ -611,6 +611,7 @@ int cpu_to_chip_id(int cpu)
>> of_node_put(np);
>> return of_get_ibm_chip_id(np);
>> }
>> +EXPORT_SYMBOL(cpu_to_chip_id);
>>
>> /* Helper routines for cpu to core mapping */
>> int cpu_core_index_of_thread(int cpu)
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2013-09-11 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 1:37 [PATCH] powerpc: Export cpu_to_chip_id() to fix build error Guenter Roeck
2013-09-10 22:03 ` Benjamin Herrenschmidt
2013-09-11 8:00 ` Vasant Hegde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5230231E.8070104@linux.vnet.ibm.com \
--to=hegdevasant@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sbhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).