From: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "jkenisto@linux.vnet.ibm.com" <jkenisto@linux.vnet.ibm.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"mahesh@linux.vnet.ibm.com" <mahesh@linux.vnet.ibm.com>,
"cbouatmailru@gmail.com" <cbouatmailru@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"ccross@android.com" <ccross@android.com>,
"seiji.aguchi@hds.com" <seiji.aguchi@hds.com>
Subject: Re: [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers
Date: Fri, 13 Sep 2013 00:52:03 +0530 [thread overview]
Message-ID: <5232145B.7070009@linux.vnet.ibm.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F31CF6AB8@ORSMSX106.amr.corp.intel.com>
On Thursday 12 September 2013 11:13 PM, Luck, Tony wrote:
> + default:
> + cmpr = 60;
> + break;
> + }
>
> Is this the right "default"? It may be a good choice for a backend with a really
> tiny buffer (1 ... 999). But less good for a (theoretical) backend with a larger
> buffer (10001 ... infinity and beyond). Which are you trying to catch here?
Trying to catch lower buffers and also tried till 23k ( 10k * 100/45) of text with a
sample crash logit achieved a good compression of 25%. Since the upper limit is
not known
and compression behavior is not tested above 10k chose to keep a higher default
of 60.
> -Tony
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2013-09-12 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:50 [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers Aruna Balakrishnaiah
2013-09-12 16:22 ` Seiji Aguchi
2013-09-12 17:43 ` Luck, Tony
2013-09-12 19:22 ` Aruna Balakrishnaiah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5232145B.7070009@linux.vnet.ibm.com \
--to=aruna@linux.vnet.ibm.com \
--cc=cbouatmailru@gmail.com \
--cc=ccross@android.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).