From: Zhang Haijun <b42677@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org, X.Xie@freescale.com,
Haijun Zhang <Haijun.Zhang@freescale.com>
Subject: Re: [PATCH] Powerpc/dts: Correct sdhci quirk for bsc9131
Date: Tue, 17 Sep 2013 08:56:23 +0800 [thread overview]
Message-ID: <5237A8B7.9020104@freescale.com> (raw)
In-Reply-To: <1379360577.2536.142.camel@snotra.buserror.net>
I see, thanks. ^_^
=E4=BA=8E 2013/9/17 3:42, Scott Wood =E5=86=99=E9=81=93:
> On Mon, 2013-09-16 at 16:12 +0800, Zhang Haijun wrote:
>> On 09/02/2013 06:37 PM, Haijun Zhang wrote:
>>> We use property "sdhci,auto-cmd12" instead of "fsl,sdhci-auto-cmd12"
>>> to distinguish if the sdhc host has quirk SDHCI_QUIRK_MULTIBLOCK_READ=
_ACMD12.
>>>
>>> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
>>> ---
>>> arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi b/arch/pow=
erpc/boot/dts/fsl/bsc9131si-post.dtsi
>>> index 5180d9d..0c0efa9 100644
>>> --- a/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
>>> +++ b/arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi
>>> @@ -130,7 +130,7 @@ usb@22000 {
>>>
>>> /include/ "pq3-esdhc-0.dtsi"
>>> sdhc@2e000 {
>>> - fsl,sdhci-auto-cmd12;
>>> + sdhci,auto-cmd12;
>>> interrupts =3D <41 0x2 0 0>;
>>> };
>>>
>>>
>>
>> Hi, scott
>>
>> Could you help review this patch?
> I process patches in periodic batches. There's no need for a reminder
> when it's only been two weeks, as long as it's still marked "new" or
> "under review" in patchwork (and you should include a patchwork link in
> any such reminder e-mail). Especially for a trivial patch such as this=
,
> no comment often means I looked at it and saw no problems and will take
> it in the next batch.
>
> Though if you want a comment, don't capitalize "powerpc" in the
> subject. :-)
>
> -Scott
>
>
--=20
Thanks & Regards
Haijun.
prev parent reply other threads:[~2013-09-17 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 10:37 [PATCH] Powerpc/dts: Correct sdhci quirk for bsc9131 Haijun Zhang
2013-09-16 8:12 ` Zhang Haijun
2013-09-16 19:42 ` Scott Wood
2013-09-17 0:56 ` Zhang Haijun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5237A8B7.9020104@freescale.com \
--to=b42677@freescale.com \
--cc=Haijun.Zhang@freescale.com \
--cc=X.Xie@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).