From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eusmtp01.atmel.com (eusmtp01.atmel.com [212.144.249.243]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C5D822C0133 for ; Mon, 23 Sep 2013 22:36:54 +1000 (EST) Message-ID: <5240355A.9010609@atmel.com> Date: Mon, 23 Sep 2013 14:34:34 +0200 From: Nicolas Ferre MIME-Version: 1.0 To: Russell King , , , , , , , , , , , , , , , , , , , , , , , Solarflare linux maintainers , Subject: Re: [PATCH 37/51] DMA-API: usb: use new dma_coerce_mask_and_coherent() References: <20130919212235.GD12758@n2100.arm.linux.org.uk> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Cc: Kukjin Kim , Stephen Warren , Alexander Shishkin , Greg Kroah-Hartman , Felipe Balbi , Tony Prisk , Alan Stern List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 20/09/2013 00:02, Russell King : > Signed-off-by: Russell King > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 4 +--- > drivers/usb/dwc3/dwc3-exynos.c | 4 +--- > drivers/usb/host/ehci-atmel.c | 4 +--- For Atmel driver: Acked-by: Nicolas Ferre [..] > diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c > index 5831a88..8e7323e 100644 > --- a/drivers/usb/host/ehci-atmel.c > +++ b/drivers/usb/host/ehci-atmel.c > @@ -90,9 +90,7 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev) > * Since shared usb code relies on it, set it here for now. > * Once we have dma capability bindings this can go away. > */ > - if (!pdev->dev.dma_mask) > - pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask; > - retval = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32)); > + retval = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > if (retval) > goto fail_create_hcd; > [..] Thanks Russell, -- Nicolas Ferre