linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: hongbo.zhang@freescale.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	ian.campbell@citrix.com, pawel.moll@arm.com,
	vinod.koul@intel.com, linux-kernel@vger.kernel.org,
	rob.herring@calxeda.com, djbw@fb.com,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes
Date: Mon, 23 Sep 2013 11:04:39 -0600	[thread overview]
Message-ID: <524074A7.7000001@wwwdotorg.org> (raw)
In-Reply-To: <1379499333-4745-3-git-send-email-hongbo.zhang@freescale.com>

On 09/18/2013 04:15 AM, hongbo.zhang@freescale.com wrote:
> From: Hongbo Zhang <hongbo.zhang@freescale.com>
> 
> Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds
> the device tree nodes for them.

> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt

> +Required properties:
> +
> +- compatible        : must include "fsl,elo3-dma"
> +- reg               : DMA General Status Registers, i.e. DGSR0 which contains
> +                      status for channel 1~4, and DGSR1 for channel 5~8

Is that a single entry, which is large enough to cover both registers,
or a pair of entries, one per register? Reading the text, I might assume
the former, but looking at the examples, it's the latter.

...
 +Example:
> +dma@100300 {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	compatible = "fsl,elo3-dma";
> +	reg = <0x100300 0x4>,
> +	      <0x100600 0x4>;

  reply	other threads:[~2013-09-23 17:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 10:15 [PATCH v10 0/3] DMA: Freescale: Add support for 8-channel DMA engine hongbo.zhang
2013-09-18 10:15 ` [PATCH v10 1/3] DMA: Freescale: revise device tree binding document hongbo.zhang
2013-09-18 10:15 ` [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes hongbo.zhang
2013-09-23 17:04   ` Stephen Warren [this message]
2013-09-24 10:30     ` Hongbo Zhang
2013-09-24 17:31       ` Stephen Warren
2013-09-25  7:35         ` Hongbo Zhang
2013-09-26  1:46           ` Scott Wood
2013-09-26  2:28             ` David Gibson
2013-09-26  5:06               ` Hongbo Zhang
2013-09-18 10:15 ` [PATCH v10 3/3] DMA: Freescale: update driver to support 8-channel DMA engine hongbo.zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524074A7.7000001@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djbw@fb.com \
    --cc=hongbo.zhang@freescale.com \
    --cc=ian.campbell@citrix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).