linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Lian Minghuan-b31939 <B31939@freescale.com>
To: Timur Tabi <timur@tabi.org>, Minghuan Lian <Minghuan.Lian@freescale.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Zang Roy-R61911 <r61911@freescale.com>,
	Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 2/2] pci: fsl: rework PCI driver compatible with Layerscape
Date: Mon, 30 Sep 2013 09:52:14 +0800	[thread overview]
Message-ID: <5248D94E.7080904@freescale.com> (raw)
In-Reply-To: <CAOZdJXUF3ibW5iuB-2p5bhPp-Uw9MVKzqZiDdukMfi4f1d3Phw@mail.gmail.com>

Hi Timur,

Thanks for your comments.

How about PCI_FSL_COMMON?

Thanks,
Minghuan

On 09/30/2013 07:56 AM, Timur Tabi wrote:
> On Wed, Sep 18, 2013 at 6:02 AM, Minghuan Lian
> <Minghuan.Lian@freescale.com> wrote:
>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 38f3b7e..6fd6348 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -690,6 +690,7 @@ config FSL_SOC
>>
>>   config FSL_PCI
>>          bool
>> +       select PCI_FSL if FSL_SOC_BOOKE || PPC_86xx
> I think having two config options, one called FSL_PCI and the other
> PCI_FSL, is very confusing.  Surely, you can pick better names than
> that?
>

  reply	other threads:[~2013-09-30  1:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 11:02 [PATCH 1/2] pci: fsl: derive the common PCI driver to drivers/pci/host Minghuan Lian
2013-09-18 11:02 ` [PATCH 2/2] pci: fsl: rework PCI driver compatible with Layerscape Minghuan Lian
2013-09-27 11:29   ` Lian Minghuan-b31939
2013-09-27 16:47     ` Scott Wood
2013-09-27 16:54   ` Scott Wood
2013-09-29 11:51     ` Lian Minghuan-b31939
2013-09-30 22:50       ` Scott Wood
2013-09-29 23:56   ` Timur Tabi
2013-09-30  1:52     ` Lian Minghuan-b31939 [this message]
2013-09-30 22:41       ` Scott Wood
2013-10-01  1:19       ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5248D94E.7080904@freescale.com \
    --to=b31939@freescale.com \
    --cc=Minghuan.Lian@freescale.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=r61911@freescale.com \
    --cc=scottwood@freescale.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).