From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: tytso@mit.edu, kvm@vger.kernel.org,
Gleb Natapov <gleb@redhat.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, herbert@gondor.hengli.com.au,
mpm@selenic.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems
Date: Tue, 01 Oct 2013 12:00:38 +0200 [thread overview]
Message-ID: <524A9D46.8050905@suse.de> (raw)
In-Reply-To: <20131001092320.GA2000@iris.ozlabs.ibm.com>
On 10/01/2013 11:23 AM, Paul Mackerras wrote:
> On Tue, Oct 01, 2013 at 11:39:08AM +0300, Gleb Natapov wrote:
>> On Tue, Oct 01, 2013 at 06:34:26PM +1000, Michael Ellerman wrote:
>>> On Thu, Sep 26, 2013 at 11:06:59AM +0200, Paolo Bonzini wrote:
>>>> Il 26/09/2013 08:31, Michael Ellerman ha scritto:
>>>>> Some powernv systems include a hwrng. Guests can access it via the
>>>>> H_RANDOM hcall.
>>>> Is there any reason to do this in the kernel?
>>> It's less code, and it's faster :)
>>>
>>>> It does not have to be a particularly fast path;
>>> Sure, but do we have to make it slow on purpose?
>>>
>> We do not put non performance critical devices into the kernel.
> It's not a device, it's a single hypercall, specified by PAPR, which
> is the moral equivalent of x86's RDRAND.
Yes, and hypercalls should be handled in user space unless impossible
otherwise (like MMU hypercalls which modify state that user space has no
priviledge to access).
I think the most reasonable way forward would be to implement the path
that jumps through hoops and goes through user space, then add a new
device in kvm that registers on this hcall inside of kvm.
That way we ensure consistency (user space knows what to put into device
tree, can disable it if it wants to, can run with TCG, etc) and you can
prove that your user space interface works along the way.
Alex
next prev parent reply other threads:[~2013-10-01 10:00 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 6:31 [PATCH 1/3] powerpc: Implement arch_get_random_long/int() for powernv Michael Ellerman
2013-09-26 6:31 ` [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems Michael Ellerman
2013-09-26 8:01 ` Benjamin Herrenschmidt
2013-10-01 8:25 ` Michael Ellerman
2013-09-26 6:31 ` [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems Michael Ellerman
2013-09-26 9:06 ` Paolo Bonzini
2013-10-01 8:34 ` Michael Ellerman
2013-10-01 8:39 ` Gleb Natapov
2013-10-01 9:23 ` Paul Mackerras
2013-10-01 9:57 ` Gleb Natapov
2013-10-01 10:00 ` Alexander Graf [this message]
2013-10-01 9:38 ` Benjamin Herrenschmidt
2013-10-01 11:19 ` Paolo Bonzini
2013-10-01 21:44 ` Benjamin Herrenschmidt
2013-10-02 8:38 ` Paolo Bonzini
2013-10-02 5:09 ` Paul Mackerras
2013-10-02 8:46 ` Paolo Bonzini
2013-10-02 9:06 ` Benjamin Herrenschmidt
2013-10-02 9:11 ` Alexander Graf
2013-10-02 9:50 ` Alexander Graf
2013-10-02 10:02 ` Gleb Natapov
2013-10-02 13:57 ` Michael Ellerman
2013-10-02 14:08 ` Alexander Graf
2013-10-02 14:33 ` Paolo Bonzini
2013-10-02 14:36 ` Alexander Graf
2013-10-02 14:38 ` Paolo Bonzini
2013-10-02 22:45 ` Paul Mackerras
2013-10-03 5:48 ` Gleb Natapov
2013-10-03 10:06 ` Paul Mackerras
2013-10-03 12:08 ` Gleb Natapov
2013-10-02 14:37 ` Gleb Natapov
2013-10-02 22:21 ` Benjamin Herrenschmidt
2013-10-03 6:08 ` Gleb Natapov
2013-10-02 22:13 ` Benjamin Herrenschmidt
2013-10-02 14:10 ` Gleb Natapov
2013-10-02 22:15 ` Benjamin Herrenschmidt
2013-10-02 22:02 ` Benjamin Herrenschmidt
2013-10-03 5:43 ` Gleb Natapov
2013-10-03 7:22 ` Benjamin Herrenschmidt
2013-10-02 22:07 ` Benjamin Herrenschmidt
2013-10-03 6:28 ` Gleb Natapov
2013-10-02 21:58 ` Benjamin Herrenschmidt
2013-10-01 9:58 ` Paolo Bonzini
2013-09-27 14:15 ` Anshuman Khandual
2013-10-01 8:36 ` Michael Ellerman
2013-09-26 7:58 ` [PATCH 1/3] powerpc: Implement arch_get_random_long/int() for powernv Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524A9D46.8050905@suse.de \
--to=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=herbert@gondor.hengli.com.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpm@selenic.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).