From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <b42378@freescale.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger()
Date: Tue, 29 Oct 2013 06:59:44 -0500 [thread overview]
Message-ID: <526FA330.3080209@tabi.org> (raw)
In-Reply-To: <1383044688-28596-1-git-send-email-b42378@freescale.com>
Nicolin Chen wrote:
> This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK
> and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will
> disable SIER_xFLAGS for symmetric.
I'm okay with this patch in principle, but why bother? The sysfs entry
is going to display all interrupts anyway, and so the result will be the
same.
next prev parent reply other threads:[~2013-10-29 11:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 11:04 [PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger() Nicolin Chen
2013-10-29 11:59 ` Timur Tabi [this message]
2013-10-29 11:57 ` Nicolin Chen
2013-10-29 12:18 ` Timur Tabi
2013-10-29 12:13 ` Nicolin Chen
2013-10-29 12:40 ` Timur Tabi
2013-10-29 13:00 ` Chen Guangyu-B42378
2013-10-29 13:14 ` Timur Tabi
2013-10-29 13:16 ` Chen Guangyu-B42378
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526FA330.3080209@tabi.org \
--to=timur@tabi.org \
--cc=alsa-devel@alsa-project.org \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).