From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175]) by ozlabs.org (Postfix) with ESMTP id 0717067BB7 for ; Fri, 20 Oct 2006 02:26:23 +1000 (EST) Received: by ug-out-1314.google.com with SMTP id 30so441141ugc for ; Thu, 19 Oct 2006 09:26:19 -0700 (PDT) Message-ID: <528646bc0610190926y380b454agf3b1bb90770a747c@mail.gmail.com> Date: Thu, 19 Oct 2006 10:26:18 -0600 From: "Grant Likely" Sender: glikely@gmail.com To: "Nicolas DET" , "Linas Vepstas" Subject: Re: [PATCH] General CHRP/MPC5K2 Platform and drivers support - to comment In-Reply-To: <20061019161855.GI6537@austin.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <453771E5.4090808@bplan-gmbh.de> <20061019161855.GI6537@austin.ibm.com> Cc: linuxppc-dev@ozlabs.org, sl@bplan-gmbh.de List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/19/06, Linas Vepstas wrote: > On Thu, Oct 19, 2006 at 02:39:01PM +0200, Nicolas DET wrote: > > This 'big' patch adds support for CHRP/MPC52xx based platform. Here, > > this is the bPlan's Efika computer > > (http://www.bplan-gmbh.de/efika_spec_en.html) > > > > We know this patch is not totaly compliant with Documentation/CodingStyle/. > > > > We would like people to comment and review it. > > Can you send the patch unzipped, and not as an attachement? > This would make reviewing and commenting much easier. Yes, and please break it up into more digestible chunks. cheers, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195