From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Timur Tabi" <timur@freescale.com>,
"linuxppc-dev list" <linuxppc-dev@ozlabs.org>
Subject: Re: QE includes in lite5200.c
Date: Wed, 6 Dec 2006 16:16:54 -0700 [thread overview]
Message-ID: <528646bc0612061516q558a3bb4x5f5f72646d27b4b8@mail.gmail.com> (raw)
In-Reply-To: <4577264E.3080406@freescale.com>
On 12/6/06, Timur Tabi <timur@freescale.com> wrote:
> Grant,
>
> I see your name is attached to arch/powerpc/platforms/lite5200.c, so I presume
> you're the one who moved it from arch/ppc to arch/powerpc. In that move, the
> following two lines were added to lite5200.c:
>
> #include <asm/qe.h>
> #include <asm/qe_ic.h>
>
> I don't think the 5200 has a QE (QUICCEngine), and I don't see any reference to
> QE code in lite5200.c. If I comment out these two lines, the code still compiles.
>
> Do you know of any reason why I shouldn't submit a patch that removes those two
> lines from arch/powerpc/platforms/lite5200.c?
Go to it; I don't know why those includes got added.
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
parent reply other threads:[~2006-12-06 23:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4577264E.3080406@freescale.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528646bc0612061516q558a3bb4x5f5f72646d27b4b8@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).