* Re: QE includes in lite5200.c
[not found] <4577264E.3080406@freescale.com>
@ 2006-12-06 23:16 ` Grant Likely
0 siblings, 0 replies; only message in thread
From: Grant Likely @ 2006-12-06 23:16 UTC (permalink / raw)
To: Timur Tabi, linuxppc-dev list
On 12/6/06, Timur Tabi <timur@freescale.com> wrote:
> Grant,
>
> I see your name is attached to arch/powerpc/platforms/lite5200.c, so I presume
> you're the one who moved it from arch/ppc to arch/powerpc. In that move, the
> following two lines were added to lite5200.c:
>
> #include <asm/qe.h>
> #include <asm/qe_ic.h>
>
> I don't think the 5200 has a QE (QUICCEngine), and I don't see any reference to
> QE code in lite5200.c. If I comment out these two lines, the code still compiles.
>
> Do you know of any reason why I shouldn't submit a patch that removes those two
> lines from arch/powerpc/platforms/lite5200.c?
Go to it; I don't know why those includes got added.
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
^ permalink raw reply [flat|nested] only message in thread