From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by ozlabs.org (Postfix) with ESMTP id 83B08DDEE8 for ; Wed, 3 Jan 2007 09:52:21 +1100 (EST) Received: by ug-out-1314.google.com with SMTP id k3so1685685ugf for ; Tue, 02 Jan 2007 14:52:21 -0800 (PST) Message-ID: <528646bc0701021452q2a8359c2y73e3caa048ab0fe3@mail.gmail.com> Date: Tue, 2 Jan 2007 15:52:20 -0700 From: "Grant Likely" Sender: glikely@gmail.com To: "Sylvain Munaut" Subject: Re: [PATCH 2/4] powerpc: 52xx, Don't use device_initcall to probe of_platform_bus In-Reply-To: <11677769982640-git-send-email-tnt@246tNt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed References: <1167776995690-git-send-email-tnt@246tNt.com> <116777699771-git-send-email-tnt@246tNt.com> <11677769982640-git-send-email-tnt@246tNt.com> Cc: Linux PPC DEV , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1/2/07, Sylvain Munaut wrote: > Using device_initcall makes it happen for every platform that > compiles this file in. This is really bad, for obvious reasons. > > Instead, we use the .init field of the machine description. If > the platform needs the hook to do something specific it can provides > its own function and call mpc52xx_declare_of_platform_devices from > there. If not, the mpc52xx_declare_of_platform_devices function can > directly be used as the init hook. > > Signed-off-by: Sylvain Munaut Acked-by: Grant Likely