From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Domen Puncer" <domen.puncer@telargo.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 3/5] mpc52xx suspend: USB
Date: Thu, 15 Mar 2007 07:24:51 -0600 [thread overview]
Message-ID: <528646bc0703150624i2bac5ce4n7beebc88d8acbafe@mail.gmail.com> (raw)
In-Reply-To: <20070315104228.GD22215@moe.telargo.com>
On 3/15/07, Domen Puncer <domen.puncer@telargo.com> wrote:
> Trivial suspend and resume OF OHCI.
> On MPC52xx turn off and on power to ports.
>
>
> Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
Nak; see below
>
> Index: grant.git/drivers/usb/host/ohci-ppc-of.c
> ===================================================================
> --- grant.git.orig/drivers/usb/host/ohci-ppc-of.c
> +++ grant.git/drivers/usb/host/ohci-ppc-of.c
> @@ -214,6 +214,32 @@ MODULE_DEVICE_TABLE(of, ohci_hcd_ppc_of_
> #endif
>
>
> +#ifdef CONFIG_PM
> +static u32 descr_a;
> +static int ohci_hcd_ppc_soc_drv_suspend(struct of_device *op,
> + pm_message_t state)
> +{
> + struct usb_hcd *hcd = dev_get_drvdata(&op->dev);
> +#ifdef CONFIG_PPC_MPC52xx
> + struct ohci_hcd *ohci = hcd_to_ohci(hcd);
> +
> + descr_a = in_be32(&ohci->regs->roothub.a);
> + out_be32(&ohci->regs->roothub.a, (descr_a & ~0x200) | 0x100);
> +#endif
> + return 0;
> +}
#ifdef blocks are a bad idea. It is now possible to boot one kernel
image on multiple platforms. Chip model should be determined ahead of
time from the device tree and choose the code path accordingly at
runtime.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-03-15 13:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-15 10:39 [PATCH 0/5 v2] MPC5200 and Lite5200b low power modes Domen Puncer
2007-03-15 10:41 ` [PATCH 1/5] mpc52xx suspend: UART Domen Puncer
2007-03-15 10:41 ` [PATCH 2/5] mpc52xx suspend: FEC (ethernet) Domen Puncer
2007-03-15 13:35 ` Grant Likely
2007-03-15 10:42 ` [PATCH 3/5] mpc52xx suspend: USB Domen Puncer
2007-03-15 13:24 ` Grant Likely [this message]
2007-03-15 14:37 ` Wrong board info for ML403 Leonid
2007-03-16 8:15 ` Andrei Konovalov
2007-03-22 7:44 ` [PATCH 3/5 v2] mpc52xx suspend: USB Domen Puncer
2007-03-23 11:56 ` Sylvain Munaut
2007-03-23 16:00 ` Grant Likely
2007-03-15 10:43 ` [PATCH 4/5] mpc52xx suspend: deep-sleep Domen Puncer
2007-03-23 15:58 ` Grant Likely
2007-04-04 7:37 ` Domen Puncer
2007-04-16 5:40 ` Grant Likely
2007-04-17 7:05 ` Domen Puncer
2007-04-17 7:10 ` Grant Likely
2007-03-15 10:44 ` [PATCH] icecube/lite5200b: wakeup from low-power support Domen Puncer
2007-03-26 16:08 ` Grant Likely
2007-04-03 8:46 ` Domen Puncer
2007-04-16 4:45 ` Grant Likely
2007-04-16 6:25 ` Domen Puncer
2007-03-31 17:20 ` Rafal Jaworowski
2007-03-31 18:38 ` Domen Puncer
2007-03-15 10:44 ` [PATCH 5/5] lite5200b suspend: low-power mode Domen Puncer
2007-03-15 14:09 ` Grant Likely
2007-03-15 16:36 ` Domen Puncer
2007-03-22 7:41 ` Domen Puncer
2007-03-26 13:23 ` Domen Puncer
2007-03-26 15:54 ` Grant Likely
2007-04-17 7:11 ` Domen Puncer
2007-04-17 7:25 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528646bc0703150624i2bac5ce4n7beebc88d8acbafe@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=domen.puncer@telargo.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).