From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Andrei Konovalov" <akonovalov@ru.mvista.com>
Cc: Rick Moleres <rick.moleres@xilinx.com>, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] Xilinx framebuffer device driver
Date: Tue, 24 Apr 2007 16:17:38 -0600 [thread overview]
Message-ID: <528646bc0704241517g595bf7bfqe54e40b05f74e933@mail.gmail.com> (raw)
In-Reply-To: <462E0D5C.1090105@ru.mvista.com>
On 4/24/07, Andrei Konovalov <akonovalov@ru.mvista.com> wrote:
> Add support for the video controller IP block included into Xilinx ML300 and
> ML403 reference designs.
>
> Signed-off-by: Andrei Konovalov <akonovalov@ru.mvista.com>
> ---
>
> This patch relies on the "Patchset to establish sanity in Xilinx Virtex support" by Gran Likely to have
> the frame buffer device registered on the platform bus. Without this patchset one needs to fill in
> the struct platform_device and make sure platform_device_register() is called elsewhere.
>
> Reviews and comments are welcome.
>
> Would be nice to get this driver into mainline for the 2.6.22.
Quick comment on first perusal: The driver uses the out_be32 macro
directly for accessing registers, which doesn't work if the FB block
is configured for DCR access (like the ML403 reference design). There
will need to be a property in the platform device binding to determine
how to access registers.
Cheers,
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-04-24 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 13:59 [PATCH] Xilinx framebuffer device driver Andrei Konovalov
2007-04-24 14:41 ` Peter Mendham
2007-04-24 22:17 ` Grant Likely [this message]
2007-04-25 13:06 ` Andrei Konovalov
2007-04-24 22:35 ` Arnd Bergmann
2007-04-25 18:06 ` Andrei Konovalov
2007-04-25 18:16 ` Andrei Konovalov
2007-04-25 18:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528646bc0704241517g595bf7bfqe54e40b05f74e933@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=akonovalov@ru.mvista.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=rick.moleres@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).