From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Peter Korsgaard" <peter.korsgaard@barco.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 2/5] [PPC] Merge common virtex header files
Date: Fri, 27 Apr 2007 12:49:26 -0600 [thread overview]
Message-ID: <528646bc0704271149w211bd5cbscb467123ab962703@mail.gmail.com> (raw)
In-Reply-To: <87d51sac8l.fsf@sleipner.barco.com>
On 4/25/07, Peter Korsgaard <peter.korsgaard@barco.com> wrote:
> >>>>> "GL" == Grant Likely <grant.likely@secretlab.ca> writes:
> GL> -#if defined(CONFIG_XILINX_ML300)
> GL> -#include <platforms/4xx/xilinx_ml300.h>
> GL> -#endif
> GL> -
> GL> -#if defined(CONFIG_XILINX_ML403)
> GL> -#include <platforms/4xx/xilinx_ml403.h>
> GL> +#if defined(CONFIG_XILINX_VIRTEX)
> GL> +#include <platforms/4xx/virtex.h>
> GL> #endif
>
> Could we make that
>
> #if defined(CONFIG_XILINX_ML300) || defined(CONFIG_XILINX_ML403)
>
> instead? I'm using RedBoot on a virtex platform, and hence another
> struct bd_info than the ML300/ML403.
Alternate suggestion: Can we change virtex support to use the
structure defined in ppcboot.h instead? (I've actually got that
change in my tree and was planning on posting it for review today or
tomorrow). bd_t is a stinking ugly mess, but things would be better
if we standardize all virtex platforms on the stinking ugly mess
shared by almost all the other ppc embedded board ports.
Cheers,
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-04-27 18:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 7:27 Patchset to establish sanity in Xilinx Virtex support Grant Likely
2007-04-15 7:27 ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Grant Likely
2007-04-15 7:27 ` [PATCH 2/5] [PPC] Merge common virtex header files Grant Likely
2007-04-15 7:27 ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Grant Likely
2007-04-15 7:27 ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Grant Likely
2007-04-15 7:27 ` [PATCH 5/5] [PPC] Add uartlite boot console driver for the zImage wrapper Grant Likely
2007-04-25 12:13 ` Peter Korsgaard
2007-04-25 12:12 ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Peter Korsgaard
2007-04-25 12:11 ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Peter Korsgaard
2007-04-27 18:50 ` Grant Likely
2007-04-25 12:07 ` [PATCH 2/5] [PPC] Merge common virtex header files Peter Korsgaard
2007-04-27 18:49 ` Grant Likely [this message]
2007-04-30 4:26 ` Peter Korsgaard
2007-04-30 4:41 ` Grant Likely
2007-05-01 4:35 ` David H. Lynch Jr.
2007-05-01 7:16 ` Grant Likely
2007-05-01 4:28 ` David H. Lynch Jr.
2007-05-01 6:54 ` Grant Likely
2007-04-15 10:48 ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Dale Farnsworth
2007-04-15 14:20 ` Grant Likely
2007-04-25 12:03 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528646bc0704271149w211bd5cbscb467123ab962703@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=linuxppc-embedded@ozlabs.org \
--cc=peter.korsgaard@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).