linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Grant Likely" <grant.likely@secretlab.ca>
To: "David H. Lynch Jr." <dhlii@dlasys.net>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH 2/5] [PPC] Merge common virtex header files
Date: Tue, 1 May 2007 01:16:33 -0600	[thread overview]
Message-ID: <528646bc0705010016i75b8c48fr5368d07b7ffcbe1b@mail.gmail.com> (raw)
In-Reply-To: <4636C377.4070101@dlasys.net>

On 4/30/07, David H. Lynch Jr. <dhlii@dlasys.net> wrote:
> There are a plethora of bd_info's in the kernel tree. I think that
> u-boot is probably the most common,
> but the u-boot one is huge and full of cruft.

Be realistic; we're talking about 124 bytes (vs 64 bytes for the pico
bd_t).  If memory consumption is a concern, there are far more
interesting targets.  ppcboot.h is butt-ugly, but at least it's
somewhat common.

> There are also likely to be any number for board/loader combinations
> that are not in the kernel.

If its not in mainline, then I'm not concerned about it because then
you're patching anyway.  I made sure it is easy to patch in a new bd_t
so nobody is screwed.

When those board ports are pushed for mainline inclusion, then we can
add the appropriate conditionals to virtex.h, but in the mean time
it's a moot point.

> But I would prefer that if there is a bd_info struct that it be defined
> by the board not virtex.h or virtex.c.

Understood, but  I do not want to encourage that approach between now
and when we jump to arch/powerpc (legacy bootloader support, yadda,
yadda).

Cheers,
g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

  reply	other threads:[~2007-05-01  7:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-15  7:27 Patchset to establish sanity in Xilinx Virtex support Grant Likely
2007-04-15  7:27 ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Grant Likely
2007-04-15  7:27   ` [PATCH 2/5] [PPC] Merge common virtex header files Grant Likely
2007-04-15  7:27     ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Grant Likely
2007-04-15  7:27       ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Grant Likely
2007-04-15  7:27         ` [PATCH 5/5] [PPC] Add uartlite boot console driver for the zImage wrapper Grant Likely
2007-04-25 12:13           ` Peter Korsgaard
2007-04-25 12:12         ` [PATCH 4/5] [PPC] Stop using ppc_sys for Xilinx Virtex boards Peter Korsgaard
2007-04-25 12:11       ` [PATCH 3/5] [PPC] New registration for common Xilinx Virtex ppc405 platform devices Peter Korsgaard
2007-04-27 18:50         ` Grant Likely
2007-04-25 12:07     ` [PATCH 2/5] [PPC] Merge common virtex header files Peter Korsgaard
2007-04-27 18:49       ` Grant Likely
2007-04-30  4:26         ` Peter Korsgaard
2007-04-30  4:41           ` Grant Likely
2007-05-01  4:35             ` David H. Lynch Jr.
2007-05-01  7:16               ` Grant Likely [this message]
2007-05-01  4:28           ` David H. Lynch Jr.
2007-05-01  6:54             ` Grant Likely
2007-04-15 10:48   ` [PATCH 1/5] [PPC] Rework Kconfig dependancies for Xilinx Virtex ppc405 platform Dale Farnsworth
2007-04-15 14:20     ` Grant Likely
2007-04-25 12:03   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528646bc0705010016i75b8c48fr5368d07b7ffcbe1b@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=dhlii@dlasys.net \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).