From: "Hong H. Pham" <hong.pham@windriver.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Cc: Paul Mackerras <paulus@samba.org>, linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCH] powerpc: Fix PTE page address mismatch in pgtable ctor/dtor
Date: Fri, 6 Dec 2013 11:15:00 -0500 [thread overview]
Message-ID: <52A1F804.5000205@windriver.com> (raw)
In-Reply-To: <874n6muuw4.fsf@linux.vnet.ibm.com>
Hi Aneesh,
On 12/06/2013 05:38 AM, Aneesh Kumar K.V wrote:
> can you also specifiy the config details here. ie, 4K page size functions
> are broken ?
My PPC64 config has SMP and 4K page size enabled. I re-tested with 64K page size,
and the problem is not present.
I have added a note that this problem affects only PPC32 and PPC64 SMP kernels.
On PPC64, the problem is limited to 4K page size.
> make it closer to what it was before,
>
> pgtable_page_dtor(table);
> pgtable_free_tlb(tlb, page_address(table), 0);
>
> This is what we had before
>
> -static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *ptepage,
> - unsigned long address)
> -{
> - tlb_flush_pgtable(tlb, address);
> - pgtable_page_dtor(ptepage);
> - pgtable_free_tlb(tlb, page_address(ptepage), 0);
> -}
>
>
> -aneesh
>
Done.
Thanks,
Hong
next prev parent reply other threads:[~2013-12-06 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 15:54 [PATCH] powerpc: Fix PTE page address mismatch in pgtable ctor/dtor Hong H. Pham
2013-12-06 10:38 ` Aneesh Kumar K.V
2013-12-06 16:15 ` Hong H. Pham [this message]
2013-12-07 14:05 ` Hong H. Pham
2013-12-06 16:17 ` [PATCH v2] " Hong H. Pham
2013-12-07 14:06 ` [PATCH v3] " Hong H. Pham
2013-12-07 20:27 ` Benjamin Herrenschmidt
2013-12-07 20:32 ` Benjamin Herrenschmidt
2013-12-09 8:41 ` Aneesh Kumar K.V
2013-12-09 8:42 ` Aneesh Kumar K.V
2013-12-15 12:59 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1F804.5000205@windriver.com \
--to=hong.pham@windriver.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).