From: Tom Musta <tommusta@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating Point Loads and Stores
Date: Thu, 12 Dec 2013 09:08:46 -0600 [thread overview]
Message-ID: <52A9D17E.3000809@gmail.com> (raw)
In-Reply-To: <20131211045728.GB9399@drongo>
On 12/10/2013 10:57 PM, Paul Mackerras wrote:
> On Wed, Dec 11, 2013 at 02:54:40PM +1100, Paul Mackerras wrote:
>> This breaks 32-bit big-endian (as well as making the code longer and
>> more complex).
>
> And in fact none of this code will get executed in little-endian mode
> anyway, since we still have this in the middle of emulate_step():
>
> /*
> * Following cases are for loads and stores, so bail out
> * if we're in little-endian mode.
> */
> if (regs->msr & MSR_LE)
> return 0;
>
> Paul.
>
See patch 1/3 to explain how it becomes relevant in LE.
I will take another look at the change.
next prev parent reply other threads:[~2013-12-12 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 18:38 [V2 PATCH 0/3] powerpc: Fix Little Endian Bugs in Single Step Code Tom
2013-10-31 18:38 ` [V2 PATCH 1/3] powerpc: Enable emulate_step In Little Endian Mode Tom
2013-11-04 2:28 ` Paul Mackerras
2013-10-31 18:38 ` [V2 PATCH 2/3] powerpc: Fix Unaligned Fixed Point Loads and Stores Tom
2013-11-04 2:34 ` Benjamin Herrenschmidt
2013-11-04 2:43 ` Paul Mackerras
2013-10-31 18:38 ` [V2 PATCH 3/3] powerpc: Fix Unaligned LE Floating " Tom
2013-11-04 2:34 ` Benjamin Herrenschmidt
2013-11-04 13:29 ` Tom Musta
2013-12-11 3:54 ` Paul Mackerras
2013-12-11 4:57 ` Paul Mackerras
2013-12-12 15:08 ` Tom Musta [this message]
2013-12-12 20:33 ` Tom Musta
2013-12-12 21:19 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9D17E.3000809@gmail.com \
--to=tommusta@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).