From: Hongbo Zhang <hongbo.zhang@freescale.com>
To: Liu Shengzhou-B36685 <Shengzhou.Liu@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Wood Scott-B07421 <scottwood@freescale.com>
Subject: Re: [PATCH 1/5] powerpc/85xx/dts: add third elo3 dma component
Date: Mon, 16 Dec 2013 17:12:44 +0800 [thread overview]
Message-ID: <52AEC40C.6000008@freescale.com> (raw)
In-Reply-To: <ae3fab730b4a45c0812d3ca5a89fce52@DM2PR03MB398.namprd03.prod.outlook.com>
On 12/13/2013 01:43 PM, Liu Shengzhou-B36685 wrote:
>
>> -----Original Message-----
>> From: Hongbo Zhang [mailto:hongbo.zhang@freescale.com]
>> Sent: Thursday, December 12, 2013 5:57 PM
>> To: Liu Shengzhou-B36685; linuxppc-dev@lists.ozlabs.org; Wood Scott-
>> B07421
>> Subject: Re: [PATCH 1/5] powerpc/85xx/dts: add third elo3 dma component
>>
>> Shengzhou,
>> I canceled my patch http://patchwork.ozlabs.org/patch/295157/ because the
>> original wrong elo3-dma-2.dtsi hadn't been merged.
>> But please pay attention to comments from Scott about my changes of
>> adding 208 for some interrupts, and take some actions if needed, or
>> further discussions.
>>
>> Below comments form Scott:
>> "The FSL MPIC binding should be updated to point out how this works.
>> Technically it's not a change to the binding itself, since it's defined
>> in terms of register offset, but the explanatory text says "So interrupt
>> 0 is at offset 0x0, interrupt 1 is at offset 0x20, and so on." which is
>> not accurate for these new high interrupt numbers."
>>
> Hongbo,
> Could you update FSL MPIC binding as Scott pointed out?
We only need to add more explanatory text after the sentence Scott
pointed out, like:
"But for some hardwares, the MPIC registers for interrupts are not
continuous in address, in such cases, an offset can be added to the
interrupt number to skip the registers which is not for interrupts."
Scott, is that OK?
Thanks.
> thanks,
> Shengzhou
next prev parent reply other threads:[~2013-12-16 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 11:19 [PATCH 1/5] powerpc/85xx/dts: add third elo3 dma component Shengzhou Liu
2013-12-11 11:19 ` [PATCH 2/5] powerpc/fsl_pci: add versionless pci compatible Shengzhou Liu
2013-12-11 11:19 ` [PATCH 3/5] powerpc/fsl-booke: Add initial device tree support for T2080/T2081 Shengzhou Liu
2013-12-11 11:19 ` [PATCH 4/5] powerpc/fsl-booke: Add initial T208x QDS board support Shengzhou Liu
2013-12-17 19:57 ` Scott Wood
2013-12-20 6:42 ` Shengzhou.Liu
2013-12-27 22:53 ` Scott Wood
2013-12-11 11:19 ` [PATCH 5/5] powerpc/fsl-booke: Enable T208xQDS board Shengzhou Liu
2013-12-12 9:57 ` [PATCH 1/5] powerpc/85xx/dts: add third elo3 dma component Hongbo Zhang
2013-12-13 5:43 ` Shengzhou.Liu
2013-12-16 9:12 ` Hongbo Zhang [this message]
2013-12-16 18:37 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AEC40C.6000008@freescale.com \
--to=hongbo.zhang@freescale.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).