From: Sudeep Holla <Sudeep.Holla@arm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ashok Raj <ashok.raj@intel.com>, Rob Herring <robh@kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sudeep.Holla@arm.com,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs
Date: Thu, 09 Jan 2014 19:07:47 +0000 [thread overview]
Message-ID: <52CEF383.3070405@arm.com> (raw)
In-Reply-To: <20140108202826.GF8417@kroah.com>
On 08/01/14 20:28, Greg Kroah-Hartman wrote:
> On Wed, Jan 08, 2014 at 07:26:06PM +0000, Sudeep Holla wrote:
>> From: Sudeep Holla <sudeep.holla@arm.com>
>> +#define define_one_ro(_name) \
>> +static struct cache_attr _name =3D \
>> +=09__ATTR(_name, 0444, show_##_name, NULL)
>=20
> In the future, we do have __ATTR_RO(), which should be used instead.
> You should never use __ATTR() on it's own, if at all possible. I'm
> sweeping the tree for all usages and fixing them slowly up over time.
>=20
Understood, will fix it.
Regards,
Sudeep
next prev parent reply other threads:[~2014-01-09 19:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1389209168-17189-1-git-send-email-sudeep.holla@arm.com>
[not found] ` <1389209168-17189-2-git-send-email-sudeep.holla@arm.com>
2014-01-08 20:26 ` [PATCH RFC 1/3] drivers: base: support cpu cache information interface to userspace via sysfs Greg Kroah-Hartman
2014-01-09 19:07 ` Sudeep Holla
2014-01-08 20:27 ` Greg Kroah-Hartman
2014-01-09 19:19 ` Sudeep Holla
2014-01-09 19:31 ` Greg Kroah-Hartman
2014-01-09 19:47 ` Sudeep Holla
2014-01-09 20:03 ` Greg Kroah-Hartman
2014-01-08 20:28 ` Greg Kroah-Hartman
2014-01-09 19:07 ` Sudeep Holla [this message]
[not found] ` <1389209168-17189-3-git-send-email-sudeep.holla@arm.com>
2014-01-08 20:57 ` [PATCH RFC 2/3] ARM: kernel: add support for cpu cache information Russell King - ARM Linux
2014-01-09 19:35 ` Sudeep Holla
2014-01-09 20:08 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CEF383.3070405@arm.com \
--to=sudeep.holla@arm.com \
--cc=ashok.raj@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).