From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp08.in.ibm.com (e28smtp08.in.ibm.com [122.248.162.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7D9CE2C0089 for ; Mon, 13 Jan 2014 14:56:50 +1100 (EST) Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Jan 2014 09:26:47 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 6996A1258051 for ; Mon, 13 Jan 2014 09:28:17 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s0D3ugOp38142090 for ; Mon, 13 Jan 2014 09:26:42 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s0D3uhCx015669 for ; Mon, 13 Jan 2014 09:26:43 +0530 Message-ID: <52D3640F.2060805@linux.vnet.ibm.com> Date: Mon, 13 Jan 2014 09:27:03 +0530 From: Deepthi Dharwar MIME-Version: 1.0 To: Preeti U Murthy Subject: Re: [PATCH] pseries/cpuidle: Remove redundant call to ppc64_runlatch_off() in cpu idle routines References: <20140109050519.11532.6044.stgit@preeti.in.ibm.com> In-Reply-To: <20140109050519.11532.6044.stgit@preeti.in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/09/2014 10:35 AM, Preeti U Murthy wrote: > Commit fbd7740fdfdf9475f switched pseries cpu idle handling from complete idle > loops to ppc_md.powersave functions. Earlier to this switch, > ppc64_runlatch_off() had to be called in each of the idle routines. But after > the switch this call is handled in arch_cpu_idle(),just before the call > to ppc_md.powersave, where platform specific idle routines are called. > > As a consequence, the call to ppc64_runlatch_off() got duplicated in the > arch_cpu_idle() routine as well as in the some of the idle routines in > pseries and commit fbd7740fdfdf9475f missed to get rid of these redundant > calls. These calls were carried over subsequent enhancements to the pseries > cpuidle routines. This patch takes care of eliminating this redundancy. > > Signed-off-by: Preeti U Murthy > --- Acked-by: Deepthi Dharwar Preeti, I will include this patch as part of the pseries cpuidle driver clean-ups series which I have undertaken. Regards, Deepthi > arch/powerpc/platforms/pseries/processor_idle.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/processor_idle.c b/arch/powerpc/platforms/pseries/processor_idle.c > index a166e38..09e4f56 100644 > --- a/arch/powerpc/platforms/pseries/processor_idle.c > +++ b/arch/powerpc/platforms/pseries/processor_idle.c > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include > #include > > struct cpuidle_driver pseries_idle_driver = { > @@ -63,7 +62,6 @@ static int snooze_loop(struct cpuidle_device *dev, > set_thread_flag(TIF_POLLING_NRFLAG); > > while ((!need_resched()) && cpu_online(cpu)) { > - ppc64_runlatch_off(); > HMT_low(); > HMT_very_low(); > } > @@ -103,7 +101,6 @@ static int dedicated_cede_loop(struct cpuidle_device *dev, > idle_loop_prolog(&in_purr); > get_lppaca()->donate_dedicated_cpu = 1; > > - ppc64_runlatch_off(); > HMT_medium(); > check_and_cede_processor(); > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >