* [PATCH] powerpc/configs: Enbale Freescale IFC controller
@ 2014-01-17 6:09 Prabhakar Kushwaha
2014-01-17 17:02 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: Prabhakar Kushwaha @ 2014-01-17 6:09 UTC (permalink / raw)
To: linuxppc-dev; +Cc: scottwood, Prabhakar Kushwaha
Currently IFC NAND driver is enabled in corenet32smp_defconfig. But IFC
controller is not enabled
So, Enable IFC controller in corenet32smp_defconfig.
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
branch master
arch/powerpc/configs/corenet32_smp_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig
index 087d437..9578cbe9 100644
--- a/arch/powerpc/configs/corenet32_smp_defconfig
+++ b/arch/powerpc/configs/corenet32_smp_defconfig
@@ -25,6 +25,7 @@ CONFIG_PARTITION_ADVANCED=y
CONFIG_MAC_PARTITION=y
CONFIG_CORENET_GENERIC=y
CONFIG_HIGHMEM=y
+CONFIG_FSL_IFC=y
# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
CONFIG_BINFMT_MISC=m
CONFIG_KEXEC=y
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/configs: Enbale Freescale IFC controller
2014-01-17 6:09 [PATCH] powerpc/configs: Enbale Freescale IFC controller Prabhakar Kushwaha
@ 2014-01-17 17:02 ` Kumar Gala
2014-01-17 18:49 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Kumar Gala @ 2014-01-17 17:02 UTC (permalink / raw)
To: Prabhakar Kushwaha; +Cc: Scott Wood, linuxppc-dev
On Jan 17, 2014, at 12:09 AM, Prabhakar Kushwaha =
<prabhakar@freescale.com> wrote:
> Currently IFC NAND driver is enabled in corenet32smp_defconfig. But =
IFC
> controller is not enabled
>=20
> So, Enable IFC controller in corenet32smp_defconfig.
>=20
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> Based upon =
git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> branch master
>=20
> arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> 1 file changed, 1 insertion(+)
Shouldn=92t the NAND driver get the IFC controller enabled by Kconfig =
dependancies?
- k=
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/configs: Enbale Freescale IFC controller
2014-01-17 17:02 ` Kumar Gala
@ 2014-01-17 18:49 ` Scott Wood
2014-01-18 3:46 ` Prabhakar Kushwaha
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2014-01-17 18:49 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Prabhakar Kushwaha
On Fri, 2014-01-17 at 11:02 -0600, Kumar Gala wrote:
> On Jan 17, 2014, at 12:09 AM, Prabhakar Kushwaha <prabhakar@freescale.com> wrote:
>
> > Currently IFC NAND driver is enabled in corenet32smp_defconfig. But IFC
> > controller is not enabled
> >
> > So, Enable IFC controller in corenet32smp_defconfig.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > ---
> > Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> > branch master
> >
> > arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> Shouldn’t the NAND driver get the IFC controller enabled by Kconfig dependancies?
Yes (by select, not dependencies).
Prabhakar, was there an actual problem you saw before? Did you run
savedefconfig after making this change?
CONFIG_FSL_IFC isn't even user-selectable (though it probably should be,
as how else would it get enabled in the absence of NAND for catching NOR
errors?).
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/configs: Enbale Freescale IFC controller
2014-01-17 18:49 ` Scott Wood
@ 2014-01-18 3:46 ` Prabhakar Kushwaha
2014-01-20 22:53 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: Prabhakar Kushwaha @ 2014-01-18 3:46 UTC (permalink / raw)
To: Scott Wood, Kumar Gala; +Cc: linuxppc-dev
On 1/18/2014 12:19 AM, Scott Wood wrote:
> On Fri, 2014-01-17 at 11:02 -0600, Kumar Gala wrote:
>> On Jan 17, 2014, at 12:09 AM, Prabhakar Kushwaha <prabhakar@freescale.=
com> wrote:
>>
>>> Currently IFC NAND driver is enabled in corenet32smp_defconfig. But I=
FC
>>> controller is not enabled
>>>
>>> So, Enable IFC controller in corenet32smp_defconfig.
>>>
>>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>>> ---
>>> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/li=
nux.git
>>> branch master
>>>
>>> arch/powerpc/configs/corenet32_smp_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>> Shouldn=E2=80=99t the NAND driver get the IFC controller enabled by Kc=
onfig dependancies?
> Yes (by select, not dependencies).
>
> Prabhakar, was there an actual problem you saw before? Did you run
> savedefconfig after making this change?
>
> CONFIG_FSL_IFC isn't even user-selectable (though it probably should be=
,
> as how else would it get enabled in the absence of NAND for catching NO=
R
> errors?).
>
Thanks Kumar and Scott for reviewing this patch.
Yes, it should be enabled by Kconfig dependency. as we have
config FSL_IFC
bool
depends on FSL_SOC
The only reason I changed this code because i wanted all powerpc/configs=20
to be similar as they have CONFIG_FSL_IFC enabled by default.
arch/powerpc/configs/mpc85xx_smp_defconfig:54:CONFIG_FSL_IFC=3Dy
arch/powerpc/configs/corenet64_smp_defconfig:29:CONFIG_FSL_IFC=3Dy
arch/powerpc/configs/mpc85xx_defconfig:51:CONFIG_FSL_IFC=3Dy
So either I should add in corenet32smp_defconfig to make similar to other=
s.
or
remove from all.
I chose first option.
Regards,
Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/configs: Enbale Freescale IFC controller
2014-01-18 3:46 ` Prabhakar Kushwaha
@ 2014-01-20 22:53 ` Scott Wood
0 siblings, 0 replies; 5+ messages in thread
From: Scott Wood @ 2014-01-20 22:53 UTC (permalink / raw)
To: Prabhakar Kushwaha; +Cc: linuxppc-dev
On Sat, 2014-01-18 at 09:16 +0530, Prabhakar Kushwaha wrote:
> On 1/18/2014 12:19 AM, Scott Wood wrote:
> > On Fri, 2014-01-17 at 11:02 -0600, Kumar Gala wrote:
> >> On Jan 17, 2014, at 12:09 AM, Prabhakar Kushwaha <prabhakar@freescale.com> wrote:
> >>
> >>> Currently IFC NAND driver is enabled in corenet32smp_defconfig. But IFC
> >>> controller is not enabled
> >>>
> >>> So, Enable IFC controller in corenet32smp_defconfig.
> >>>
> >>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> >>> ---
> >>> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git
> >>> branch master
> >>>
> >>> arch/powerpc/configs/corenet32_smp_defconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >> Shouldn’t the NAND driver get the IFC controller enabled by Kconfig dependancies?
> > Yes (by select, not dependencies).
> >
> > Prabhakar, was there an actual problem you saw before? Did you run
> > savedefconfig after making this change?
> >
> > CONFIG_FSL_IFC isn't even user-selectable (though it probably should be,
> > as how else would it get enabled in the absence of NAND for catching NOR
> > errors?).
> >
>
> Thanks Kumar and Scott for reviewing this patch.
>
> Yes, it should be enabled by Kconfig dependency. as we have
> config FSL_IFC
> bool
> depends on FSL_SOC
>
> The only reason I changed this code because i wanted all powerpc/configs
> to be similar as they have CONFIG_FSL_IFC enabled by default.
>
> arch/powerpc/configs/mpc85xx_smp_defconfig:54:CONFIG_FSL_IFC=y
> arch/powerpc/configs/corenet64_smp_defconfig:29:CONFIG_FSL_IFC=y
> arch/powerpc/configs/mpc85xx_defconfig:51:CONFIG_FSL_IFC=y
>
> So either I should add in corenet32smp_defconfig to make similar to others.
> or
> remove from all.
>
> I chose first option.
Those other defconfigs are wrong, since they differ from what you'd get
after running "make savedefconfig".
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-20 22:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-17 6:09 [PATCH] powerpc/configs: Enbale Freescale IFC controller Prabhakar Kushwaha
2014-01-17 17:02 ` Kumar Gala
2014-01-17 18:49 ` Scott Wood
2014-01-18 3:46 ` Prabhakar Kushwaha
2014-01-20 22:53 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).