From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 442352C007A for ; Mon, 27 Jan 2014 19:23:50 +1100 (EST) Received: by mail-we0-f175.google.com with SMTP id p61so4924403wes.34 for ; Mon, 27 Jan 2014 00:23:46 -0800 (PST) Message-ID: <52E61793.4020608@linaro.org> Date: Mon, 27 Jan 2014 09:23:47 +0100 From: Daniel Lezcano MIME-Version: 1.0 To: Nicolas Pitre , Russell King , Catalin Marinas , Benjamin Herrenschmidt , Paul Mundt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" Subject: Re: [PATCH 2/9] ARM64: get rid of arch_cpu_idle_prepare() References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-3-git-send-email-nicolas.pitre@linaro.org> In-Reply-To: <1390802904-28399-3-git-send-email-nicolas.pitre@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/27/2014 07:08 AM, Nicolas Pitre wrote: > ARM and ARM64 are the only two architectures implementing > arch_cpu_idle_prepare() simply to call local_fiq_enable(). > > We have secondary_start_kernel() already calling local_fiq_enable() and > this is done a second time in arch_cpu_idle_prepare() in that case. And > enabling FIQs has nothing to do with idling the CPU to start with. > > So let's introduce init_fiq_boot_cpu() to take care of FIQs on the boot > CPU and remove arch_cpu_idle_prepare(). This is now done a bit earlier > at late_initcall time but this shouldn't make a difference in practice > given that FIQs are not currently used on ARM64. > > Signed-off-by: Nicolas Pitre Reviewed-by: Daniel Lezcano > --- > arch/arm64/kernel/process.c | 5 ----- > arch/arm64/kernel/setup.c | 7 +++++++ > 2 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index de17c89985..f6c733da67 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -84,11 +84,6 @@ EXPORT_SYMBOL_GPL(pm_power_off); > void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd); > EXPORT_SYMBOL_GPL(arm_pm_restart); > > -void arch_cpu_idle_prepare(void) > -{ > - local_fiq_enable(); > -} > - > /* > * This is our default idle handler. > */ > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index bd9bbd0e44..259557983a 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -255,6 +255,13 @@ static int __init arm64_device_init(void) > } > arch_initcall(arm64_device_init); > > +static int __init init_fiq_boot_cpu(void) > +{ > + local_fiq_enable(); > + return 0; > +} > +late_initcall(init_fiq_boot_cpu); > + > static DEFINE_PER_CPU(struct cpu, cpu_data); > > static int __init topology_init(void) > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog