From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6D5152C0091 for ; Mon, 27 Jan 2014 19:33:16 +1100 (EST) Received: by mail-wg0-f53.google.com with SMTP id y10so5235735wgg.20 for ; Mon, 27 Jan 2014 00:33:12 -0800 (PST) Message-ID: <52E619C9.4050406@linaro.org> Date: Mon, 27 Jan 2014 09:33:13 +0100 From: Daniel Lezcano MIME-Version: 1.0 To: Nicolas Pitre , Russell King , Catalin Marinas , Benjamin Herrenschmidt , Paul Mundt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" Subject: Re: [PATCH 5/9] ARM: remove redundant cpuidle_idle_call() References: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org> <1390802904-28399-6-git-send-email-nicolas.pitre@linaro.org> In-Reply-To: <1390802904-28399-6-git-send-email-nicolas.pitre@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/27/2014 07:08 AM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre Acked-by: Daniel Lezcano > --- > arch/arm/kernel/process.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c > index 725b8c95e0..34a59b7614 100644 > --- a/arch/arm/kernel/process.c > +++ b/arch/arm/kernel/process.c > @@ -30,7 +30,6 @@ > #include > #include > #include > -#include > #include > #include > > @@ -133,7 +132,11 @@ EXPORT_SYMBOL_GPL(arm_pm_restart); > > void (*arm_pm_idle)(void); > > -static void default_idle(void) > +/* > + * Called from the core idle loop. > + */ > + > +void arch_cpu_idle(void) > { > if (arm_pm_idle) > arm_pm_idle(); > @@ -163,15 +166,6 @@ void arch_cpu_idle_dead(void) > #endif > > /* > - * Called from the core idle loop. > - */ > -void arch_cpu_idle(void) > -{ > - if (cpuidle_idle_call()) > - default_idle(); > -} > - > -/* > * Called by kexec, immediately prior to machine_kexec(). > * > * This must completely disable all secondary CPUs; simply causing those CPUs > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog