From: Preeti U Murthy <preeti@linux.vnet.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: daniel.lezcano@linaro.org, peterz@infradead.org,
fweisbec@gmail.com, agraf@suse.de, paul.gortmaker@windriver.com,
paulus@samba.org, mingo@kernel.org, mikey@neuling.org,
shangw@linux.vnet.ibm.com, rafael.j.wysocki@intel.com,
paulmck@linux.vnet.ibm.com, arnd@arndb.de,
linux-pm@vger.kernel.org, rostedt@goodmis.org,
michael@ellerman.id.au, john.stultz@linaro.org, anton@samba.org,
chenhui.zhao@freescale.com, deepthi@linux.vnet.ibm.com,
r58472@freescale.com, geoff@infradead.org,
linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com,
schwidefsky@de.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer
Date: Tue, 04 Feb 2014 22:44:48 +0530 [thread overview]
Message-ID: <52F12008.4040103@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1402041100250.24986@ionos.tec.linutronix.de>
On 02/04/2014 03:31 PM, Thomas Gleixner wrote:
> On Fri, 24 Jan 2014, Preeti U Murthy wrote:
>> -extern void tick_broadcast_oneshot_control(unsigned long reason);
>> +extern int tick_broadcast_oneshot_control(unsigned long reason);
>
>> -static inline void tick_broadcast_oneshot_control(unsigned long reason) { }
>> +static inline int tick_broadcast_oneshot_control(unsigned long reason) { }
>
>> -static inline void tick_broadcast_oneshot_control(unsigned long reason) { }
>> +static inline int tick_broadcast_oneshot_control(unsigned long reason) { }
>
> The inline stubs need to return 0.
Oh right! Apologies!
Thanks.
>
> Thanks,
>
> tglx
>
Regards
Preeti U Murthy
next prev parent reply other threads:[~2014-02-04 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 6:57 [PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device Preeti U Murthy
2014-01-24 6:57 ` [PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer Preeti U Murthy
2014-02-04 10:01 ` Thomas Gleixner
2014-02-04 17:14 ` Preeti U Murthy [this message]
2014-01-24 6:58 ` [PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast Preeti U Murthy
2014-02-04 10:18 ` Thomas Gleixner
2014-02-04 17:09 ` Preeti U Murthy
2014-02-04 20:18 ` Thomas Gleixner
2014-01-28 10:49 ` [PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F12008.4040103@linux.vnet.ibm.com \
--to=preeti@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=anton@samba.org \
--cc=arnd@arndb.de \
--cc=chenhui.zhao@freescale.com \
--cc=daniel.lezcano@linaro.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=geoff@infradead.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=r58472@freescale.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=schwidefsky@de.ibm.com \
--cc=shangw@linux.vnet.ibm.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).