From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A1C2D591AC for ; Mon, 18 Nov 2024 18:09:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XsbJ05JnZz3bXn; Tue, 19 Nov 2024 05:09:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731953392; cv=none; b=mtZ8qhN81aL4FpldnJ+b+QyGmug+IpRIpKussnO2C4FDKpZSL+2ZAbWJtC1tdQPv88MOG5JhOu96n5Wd+edMQOAgoqur+958/oLR86IXcYoD0vlPEZ0QFCRcLOlmYWf878ccXvYSgXmz+ygtueHJdJEJtJ5raGtc4tVlmJF5qk2aq/N0l5Zmh7KSFpmc4bEFG+m+T6GILW6wQ0hJRSB5CS0MvSNVoD6OjIV05OKtDWjl/p8mXVB0EjU5tYsj1rVkeFbBfBF5sCy7BNtWNjO+HySB3rcScyIsz3HVSl5EP8oJDOF7fnwAyaWANq4zeTGI0n7bzG50Wd5SYB+G8/5Afg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1731953392; c=relaxed/relaxed; bh=wR2vAxb4KjC7bChWhYgHEm7VYOkoUSKJ2zrGmmUQgeU=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=nzrb72hghNu9OrqnY5zagTqPUTT+mRbuXLQUUmza6GGJDT/dG5hYl+gP7TqLgDc82oJxmP06o2Os4cg1oFyM35tD3Sd8aUY4nvrahTELo9dzhDr3reUdFWT/OBWp6eH3XHrG8Yt8LJvsrho9pYNgpGy89Wspb2LcuPO9a69OX5QYDDKgnbuQw8h/NLkFzMbYlW+RRNU/d/AIpcsis0i8t/Oa0L6+AEKPKdT4rNTajjfwgoEbfuFhqh044qTWbvig6x0ifiHP1YBXKQO+/xQUdGQ4sFWNgfqnrSUZOplub3QIKH8+OYT/6lbJFVGgaItIQ1gnagmb8baOPuairsTQEA== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=QcXvfQn3; dkim-atps=neutral; spf=pass (client-ip=13.77.154.182; helo=linux.microsoft.com; envelope-from=eahariha@linux.microsoft.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.microsoft.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=QcXvfQn3; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.microsoft.com (client-ip=13.77.154.182; helo=linux.microsoft.com; envelope-from=eahariha@linux.microsoft.com; receiver=lists.ozlabs.org) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lists.ozlabs.org (Postfix) with ESMTP id 4XsbHz571Fz3039 for ; Tue, 19 Nov 2024 05:09:51 +1100 (AEDT) Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id B3D1220BEBD0; Mon, 18 Nov 2024 10:09:17 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B3D1220BEBD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731953360; bh=wR2vAxb4KjC7bChWhYgHEm7VYOkoUSKJ2zrGmmUQgeU=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=QcXvfQn32bbEJk/CliGqPjJlSoPmzpqy39Cb7yWbUp/UMAorBMUaWUr/NKZ9e69DC EuA6BiEwniO9Hz9jAZdoaPATG/Z4etAtwQMMCiIdSJ0wltRFnatVskzJPAClKWSWJ2 IoOFaRlq/Uc2MlJVJm0M77F7OwMbRuycEwh39LjI= Message-ID: <52cc0733-49fc-4452-99c6-8c18bf20dde7@linux.microsoft.com> Date: Mon, 18 Nov 2024 10:09:17 -0800 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, James.Bottomley@HansenPartnership.com, Julia.Lawall@inria.fr, agordeev@linux.ibm.com, airlied@gmail.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, anna-maria@linutronix.de, ath11k@lists.infradead.org, axboe@kernel.dk, bcm-kernel-feedback-list@broadcom.com, borntraeger@linux.ibm.com, catalin.marinas@arm.com, ceph-devel@vger.kernel.org, christian.gmeiner@gmail.com, christophe.leroy@csgroup.eu, cocci@inria.fr, coreteam@netfilter.org, daniel@zonque.org, davem@davemloft.net, dick.kennedy@broadcom.com, dri-devel@lists.freedesktop.org, edumazet@google.com, etnaviv@lists.freedesktop.org, florian.fainelli@broadcom.com, gor@linux.ibm.com, gregkh@linuxfoundation.org, haojian.zhuang@gmail.com, hca@linux.ibm.com, horms@kernel.org, idryomov@gmail.com, intel-xe@lists.freedesktop.org, james.smart@broadcom.com, jeroendb@google.com, jikos@kernel.org, jinpu.wang@cloud.ionos.com, jjohnson@kernel.org, joe.lawrence@redhat.com, johan.hedberg@gmail.com, jpoimboe@kernel.org, kadlec@netfilter.org, kuba@kernel.org, kvalo@kernel.org, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rpi-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, louis.peens@corigine.com, lucas.demarchi@intel.com, luiz.dentz@gmail.com, maarten.lankhorst@linux.intel.com, maddy@linux.ibm.com, marcel@holtmann.org, martin.petersen@oracle.com, mbenes@suse.cz, mpe@ellerman.id.au, mripard@kernel.org, naveen@kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nicolas.palix@imag.fr, npiggin@gmail.com, obitton@habana.ai, ogabbay@kernel.org, oss-drivers@corigine.com, pabeni@redhat.com, pablo@netfilter.org, perex@perex.cz, pkaligineedi@google.com, pmladek@suse.com, rjui@broadcom.com, robert.jarzmik@free.fr, rodrigo.vivi@intel.com, roger.pau@citrix.com, sbranden@broadcom.com, shailend@google.com, simona@ffwll.ch, svens@linux.ibm.com, thomas.hellstrom@linux.intel.com, tiwai@suse.com, tzimmermann@suse.de, xen-devel@lists.xenproject.org, xiubli@redhat.com Subject: Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script To: Christophe JAILLET References: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> From: Easwar Hariharan Content-Language: en-US In-Reply-To: <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/15/2024 10:05 PM, Christophe JAILLET wrote: > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> Suggested-by: Anna-Maria Behnsen >> Signed-off-by: Easwar Hariharan >> --- >> scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> new file mode 100644 >> index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 >> --- /dev/null >> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci >> @@ -0,0 +1,21 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/// >> +/// Find usages of: >> +/// - msecs_to_jiffies(value*1000) >> +/// - msecs_to_jiffies(value*MSEC_PER_SEC) >> +/// >> +// Confidence: High >> +// Copyright: (C) 2024 Easwar Hariharan Microsoft >> +// >> +// Keywords: secs, seconds, jiffies >> +// >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * 1000) >> ++ secs_to_jiffies(C) >> + >> +@@ constant C; @@ >> + >> +- msecs_to_jiffies(C * MSEC_PER_SEC) >> ++ secs_to_jiffies(C) >> > Hi, > > @@ constant C =~ "000"; @@ > > * msecs_to_jiffies(C) > > also spots things like msecs_to_jiffies(1000) > > I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. > > Just my 2c, > > CJ Thank you, I'll try that rule for the later parts. Thank you all for helping with writing Coccinelle rules, I'm not familiar with metaprogramming in general and Coccinelle in particular, so these are super helpful. - Easwar