Re: [PATCH 1/2] update crypto node definition and device tree instances

[Segher Boessenkool <segher@kernel.crashing.org>]

Nice cleanup!  Just one thing...

> +    - compatible : Should contain entries for all compatible SEC 
> versions,
> +      high to low, e.g., "fsl,sec2.1", "fsl,sec2.0"

*All* compatible versions?  That's not really correct -- for
example that would include *future* versions!

The first entry should describe the exact device version.  If
there are more entries, they should be for device versions where
the driver for that device version can be reasonably expected to
do something useful with this newer device (reduced functionality,
perhaps).  Listing *all* compatible devices is a) infeasible,
b) not useful, and c) insane :-)

Say you have a 3.3 device, and all 3.x devices have the same
programming interface; also, the 2.x interface works with reduced
functionality, and 1.x isn't useful at all; in that case, you would
list 3.3, 3.0, 2.0.  The driver that knows about 3.x would probe
for 3.0, while an older driver would probe for 2.0.  The driver
doesn't need to probe for 3.3, since devices implementing 3.3
should show they are compatible with 3.0 (and the binding should
say they should show this).

Also, the binding should explicitly list all defined compatible
entries (and what they mean), not just give a few examples.


Segher