linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* pci_unmap_single() and CONFIG_NOT_COHERENT_CACHE
@ 2003-05-09 18:07 Curtis, Allen
  2003-05-09 18:28 ` Roland Dreier
  0 siblings, 1 reply; 3+ messages in thread
From: Curtis, Allen @ 2003-05-09 18:07 UTC (permalink / raw)
  To: 'linuxppc-embedded@lists.linuxppc.org'


I noticed in pci.h that pci_unmap_single() is a null function. (essentially
does nothing) Shouldn't is call consistent_sync() so that
flush_dcache_range() is called?


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: pci_unmap_single() and CONFIG_NOT_COHERENT_CACHE
  2003-05-09 18:07 pci_unmap_single() and CONFIG_NOT_COHERENT_CACHE Curtis, Allen
@ 2003-05-09 18:28 ` Roland Dreier
  0 siblings, 0 replies; 3+ messages in thread
From: Roland Dreier @ 2003-05-09 18:28 UTC (permalink / raw)
  To: Curtis, Allen; +Cc: 'linuxppc-embedded@lists.linuxppc.org'


    Allen> I noticed in pci.h that pci_unmap_single() is a null
    Allen> function. (essentially does nothing) Shouldn't is call
    Allen> consistent_sync() so that flush_dcache_range() is called?

No, the cache invalidate or flush has to happen when pci_map_single()
is used.  There's nothing to do after the DMA is done (which is when
pci_unmap_single() gets called).

 - Roland

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: pci_unmap_single() and CONFIG_NOT_COHERENT_CACHE
@ 2003-05-09 19:54 Curtis, Allen
  0 siblings, 0 replies; 3+ messages in thread
From: Curtis, Allen @ 2003-05-09 19:54 UTC (permalink / raw)
  To: 'Roland Dreier', Curtis, Allen
  Cc: 'linuxppc-embedded@lists.linuxppc.org'


>
>    Allen> I noticed in pci.h that pci_unmap_single() is a null
>    Allen> function. (essentially does nothing) Shouldn't is call
>    Allen> consistent_sync() so that flush_dcache_range() is called?
>
>No, the cache invalidate or flush has to happen when pci_map_single()
>is used.  There's nothing to do after the DMA is done (which is when
>pci_unmap_single() gets called).
>

Thanks, shortly after pressing the send button I realized that this was a
dumb question.


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-05-09 19:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-09 18:07 pci_unmap_single() and CONFIG_NOT_COHERENT_CACHE Curtis, Allen
2003-05-09 18:28 ` Roland Dreier
  -- strict thread matches above, loose matches on Subject: below --
2003-05-09 19:54 Curtis, Allen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).