From: Roland Dreier <rolandd@cisco.com>
To: "Ruslan V. Sushko" <rsushko@ru.mvista.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 1/3] ppc32: Fix a few issues in Yucca PCIe functionality
Date: Wed, 30 Nov 2005 10:09:42 -0800 [thread overview]
Message-ID: <52veyaqa6x.fsf@cisco.com> (raw)
In-Reply-To: <1132763364.31328.21.camel@mephisto.spb.rtsoft.ru> (Ruslan V. Sushko's message of "Wed, 23 Nov 2005 19:29:24 +0300")
This looks OK, although I would prefer to see this split into a few
patches, for example, first kill off dead code, then add more error
checking, and so on.
Also, one question/comment:
> @@ -335,44 +337,47 @@ int ppc440spe_init_pcie_rootport(int por
> /*
> * Check for VC0 active and assert RDY.
> */
> +
> + attempts = 10;
> switch (port) {
> case 0:
> - if (!(SDR_READ(PESDR0_RCSSTS) & (1 << 16)))
> - printk(KERN_WARNING "PCIE0: VC0 not active\n");
> + while(!(SDR_READ(PESDR0_RCSSTS) & (1 << 16))) {
> + if (!(attempts--)) {
> + printk(KERN_WARNING "PCIE0: VC0 not active\n");
> + return -1;
> + }
> + mdelay(1000);
> + }
> SDR_WRITE(PESDR0_RCSSET, SDR_READ(PESDR0_RCSSET) | 1 << 20);
what lead you to add 10 tries here? Did this fix an issue you saw
with a device?
- R.
next prev parent reply other threads:[~2005-11-30 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 14:25 [PATCH 1/3] ppc32: Fix a few issues in Yucca PCIe functionality Ruslan V. Sushko
2005-11-21 17:47 ` Dale Farnsworth
2005-11-23 16:29 ` Ruslan V. Sushko
2005-11-30 18:09 ` Roland Dreier [this message]
2005-11-23 16:29 ` [PATCH 2/3] ppc32: PCIX support for Yucca board Ruslan V. Sushko
2005-11-30 18:11 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52veyaqa6x.fsf@cisco.com \
--to=rolandd@cisco.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=rsushko@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).