From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Linux PPC <linuxppc-dev@lists.ozlabs.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>,
Anton Blanchard <anton@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Kumar Gala <galak@kernel.crashing.org>,
Lijun Pan <Lijun.Pan@freescale.com>,
Li Yang <leoli@freescale.com>, Paul Bolle <pebolle@tiscali.nl>,
Priyanka Jain <Priyanka.Jain@freescale.com>,
Scott Wood <scottwood@freescale.com>,
Tang Yuantian <yuantian.tang@freescale.com>
Cc: Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Date: Tue, 25 Feb 2014 13:31:13 -0800 [thread overview]
Message-ID: <530D0BA1.90609@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140225033330.54F332C02FB@ozlabs.org>
On 02/24/2014 07:33 PM, Michael Ellerman wrote:
> On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote:
>> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/perf/Makefile | 2 ++
>> arch/powerpc/platforms/Kconfig.cputype | 6 ++++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile
>> index 60d71ee..f9c083a 100644
>> --- a/arch/powerpc/perf/Makefile
>> +++ b/arch/powerpc/perf/Makefile
>> @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o
>> obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o
>> obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o
>>
>> +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o
>> +
>> obj-$(CONFIG_PPC64) += $(obj64-y)
>> obj-$(CONFIG_PPC32) += $(obj32-y)
>> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
>> index 434fda3..dcc67cd 100644
>> --- a/arch/powerpc/platforms/Kconfig.cputype
>> +++ b/arch/powerpc/platforms/Kconfig.cputype
>> @@ -364,6 +364,12 @@ config PPC_PERF_CTRS
>> help
>> This enables the powerpc-specific perf_event back-end.
>>
>> +config HV_PERF_CTRS
>> + def_bool y
>
> This was bool, why did you change it?
No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518
Maybe you're confusing v2.1 and v2 of this patch?
>
>> + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT
>
> Should be:
>
> depends on PERF_EVENTS && PPC_PSERIES
>
>> + help
>> + Enable access to perf counters provided by the hypervisor
>> +
Yep, the v2.1 patch (which I bungled and labeled as 9/11) already
changes both of these.
It'll end up rolled into v3.
next prev parent reply other threads:[~2014-02-25 21:31 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 22:02 [PATCH v2 00/11] powerpc: Add support for Power Hypervisor supplied performance counters Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 01/11] perf: add PMU_RANGE_ATTR() helper for use by sw-like pmus Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 20:33 ` Cody P Schafer
2014-02-25 22:19 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 02/11] perf core: export swevent hrtimer helpers Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 10:20 ` Peter Zijlstra
2014-02-25 21:38 ` Cody P Schafer
2014-02-26 8:29 ` Peter Zijlstra
2014-02-27 19:33 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 03/11] sysfs: create bin_attributes under the requested group Cody P Schafer
2014-02-15 20:15 ` Greg Kroah-Hartman
2014-02-25 3:33 ` Michael Ellerman
2014-02-14 22:02 ` [PATCH v2 04/11] powerpc: add hvcalls for 24x7 and gpci (get performance counter info) Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:13 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 05/11] powerpc: add hv_gpci interface header Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 20:35 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 06/11] powerpc: add 24x7 " Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 07/11] powerpc: add a shared interface to get gpci version and capabilities Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:20 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 08/11] powerpc/perf: add support for the hv gpci (get performance counter info) interface Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 21:25 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 09/11] powerpc/perf: add support for the hv 24x7 interface Cody P Schafer
2014-02-25 3:33 ` Michael Ellerman
2014-02-25 20:55 ` Cody P Schafer
2014-02-14 22:02 ` [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters Cody P Schafer
2014-02-14 22:32 ` Scott Wood
2014-02-15 0:25 ` Cody P Schafer
2014-02-17 7:11 ` Michael Ellerman
2014-02-17 19:41 ` Cody P Schafer
2014-02-21 0:14 ` [PATCH v2.1 9/11] " Cody P Schafer
2014-02-21 0:24 ` Cody P Schafer
2014-02-25 3:33 ` [PATCH v2 10/11] " Michael Ellerman
2014-02-25 21:31 ` Cody P Schafer [this message]
2014-02-26 3:48 ` Michael Ellerman
2014-02-14 22:02 ` [PATCH v2 11/11] powerpc/perf/hv_{gpci, 24x7}: add documentation of device attributes Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530D0BA1.90609@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=Lijun.Pan@freescale.com \
--cc=Priyanka.Jain@freescale.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=pebolle@tiscali.nl \
--cc=scottwood@freescale.com \
--cc=yuantian.tang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).