From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Linux PPC <linuxppc-dev@lists.ozlabs.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Peter Zijlstra <peterz@infradead.org>,
scottwood@freescale.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx
Date: Mon, 03 Mar 2014 23:01:25 -0800 [thread overview]
Message-ID: <53157A45.4080600@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140304051936.97CBF2C020A@ozlabs.org>
On 03/03/2014 09:19 PM, Michael Ellerman wrote:
> On Thu, 2014-27-02 at 21:04:56 UTC, Cody P Schafer wrote:
>> Rather an having every pmu that needs a function that just returns 0 for
>> .event_idx define their own copy, reuse the one in kernel/events/core.c.
>>
>> Rename from perf_swevent_event_idx() because we're no longer using it
>> for just software events. Naming is based on the perf_pmu_nop_*()
>> functions.
>
> You could just use perf_pmu_nop_int() directly.
No, .event_idx needs something that takes a (struct perf_event *),
perf_pmu_nop_int() takes a (struct pmu *).
next prev parent reply other threads:[~2014-03-04 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 21:04 [PATCH v3 00/11] powerpc: Add support for Power Hypervisor supplied performance counters Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 01/11] sysfs: create bin_attributes under the requested group Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 02/11] perf: add PMU_FORMAT_RANGE() helper for use by sw-like pmus Cody P Schafer
2014-03-04 5:19 ` Michael Ellerman
2014-03-04 8:09 ` Cody P Schafer
2014-03-06 0:05 ` Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx Cody P Schafer
2014-03-04 5:19 ` Michael Ellerman
2014-03-04 7:01 ` Cody P Schafer [this message]
2014-03-05 1:19 ` Michael Ellerman
2014-02-27 21:04 ` [PATCH v3 04/11] powerpc: add hvcalls for 24x7 and gpci (get performance counter info) Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 05/11] powerpc/perf: add hv_gpci interface header Cody P Schafer
2014-02-27 21:04 ` [PATCH v3 06/11] powerpc/perf: add 24x7 interface headers Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 07/11] powerpc/perf: add a shared interface to get gpci version and capabilities Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 08/11] powerpc/perf: add support for the hv gpci (get performance counter info) interface Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 09/11] powerpc/perf: add support for the hv 24x7 interface Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 10/11] powerpc/perf: add kconfig option for hypervisor provided counters Cody P Schafer
2014-02-27 21:05 ` [PATCH v3 11/11] powerpc/perf/hv_{gpci, 24x7}: add documentation of device attributes Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53157A45.4080600@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).