linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: Align p_dyn, p_rela and p_st symbols
@ 2014-03-03 21:31 Anton Blanchard
  2014-03-04 15:45 ` Laurent Dufour
  0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2014-03-03 21:31 UTC (permalink / raw)
  To: benh, paulus, ldufour; +Cc: linuxppc-dev


The 64bit relocation code places a few symbols in the text segment.
These symbols are only 4 byte aligned where they need to be 8 byte
aligned. Add an explicit alignment.

Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: stable@vger.kernel.org
---

diff --git a/arch/powerpc/kernel/reloc_64.S b/arch/powerpc/kernel/reloc_64.S
index 1482327..d88736f 100644
--- a/arch/powerpc/kernel/reloc_64.S
+++ b/arch/powerpc/kernel/reloc_64.S
@@ -81,6 +81,7 @@ _GLOBAL(relocate)
 
 6:	blr
 
+.balign 8
 p_dyn:	.llong	__dynamic_start - 0b
 p_rela:	.llong	__rela_dyn_start - 0b
 p_st:	.llong	_stext - 0b

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc: Align p_dyn, p_rela and p_st symbols
  2014-03-03 21:31 [PATCH] powerpc: Align p_dyn, p_rela and p_st symbols Anton Blanchard
@ 2014-03-04 15:45 ` Laurent Dufour
  0 siblings, 0 replies; 2+ messages in thread
From: Laurent Dufour @ 2014-03-04 15:45 UTC (permalink / raw)
  To: Anton Blanchard, benh, paulus; +Cc: linuxppc-dev

On 03/03/2014 22:31, Anton Blanchard wrote:
> 
> The 64bit relocation code places a few symbols in the text segment.
> These symbols are only 4 byte aligned where they need to be 8 byte
> aligned. Add an explicit alignment.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Cc: stable@vger.kernel.org

Fix the issue I was seeing when booting a LE kernel in a KVM guest on my
P7 box.

Tested-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>

> ---
> 
> diff --git a/arch/powerpc/kernel/reloc_64.S b/arch/powerpc/kernel/reloc_64.S
> index 1482327..d88736f 100644
> --- a/arch/powerpc/kernel/reloc_64.S
> +++ b/arch/powerpc/kernel/reloc_64.S
> @@ -81,6 +81,7 @@ _GLOBAL(relocate)
>  
>  6:	blr
>  
> +.balign 8
>  p_dyn:	.llong	__dynamic_start - 0b
>  p_rela:	.llong	__rela_dyn_start - 0b
>  p_st:	.llong	_stext - 0b
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-04 15:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-03 21:31 [PATCH] powerpc: Align p_dyn, p_rela and p_st symbols Anton Blanchard
2014-03-04 15:45 ` Laurent Dufour

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).