* [PATCH] phy/at8031: enable at8031 to work on interrupt mode
@ 2014-03-27 6:18 Zhao Qiang
2014-03-27 11:52 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Zhao Qiang @ 2014-03-27 6:18 UTC (permalink / raw)
To: linuxppc-dev, netdev, B07421
Cc: mugunthanvnm, Zhao Qiang, linux-kernel, helmut.schaa, zonque,
R63061, davem
The at8031 can work on polling mode and interrupt mode.
Add ack_interrupt and config intr funcs to enable
interrupt mode for it.
Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index bc71947..d034ef5 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -27,6 +27,9 @@
#define AT803X_MMD_ACCESS_CONTROL 0x0D
#define AT803X_MMD_ACCESS_CONTROL_DATA 0x0E
#define AT803X_FUNC_DATA 0x4003
+#define AT803X_INER 0x0012
+#define AT803X_INER_INIT 0xec00
+#define AT803X_INSR 0x0013
#define AT803X_DEBUG_ADDR 0x1D
#define AT803X_DEBUG_DATA 0x1E
#define AT803X_DEBUG_SYSTEM_MODE_CTRL 0x05
@@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device *phydev)
return 0;
}
+static int at803x_ack_interrupt(struct phy_device *phydev)
+{
+ int err;
+
+ err = phy_read(phydev, AT803X_INSR);
+
+ return (err < 0) ? err : 0;
+}
+
+static int at803x_config_intr(struct phy_device *phydev)
+{
+ int err;
+ int value;
+
+ value = phy_read(phydev, AT803X_INER);
+
+ if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
+ err = phy_write(phydev, AT803X_INER,
+ (value | AT803X_INER_INIT));
+ else
+ err = phy_write(phydev, AT803X_INER, value);
+
+ return err;
+}
+
static struct phy_driver at803x_driver[] = {
{
/* ATHEROS 8035 */
@@ -240,6 +268,8 @@ static struct phy_driver at803x_driver[] = {
.flags = PHY_HAS_INTERRUPT,
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
+ .ack_interrupt = &at803x_ack_interrupt,
+ .config_intr = &at803x_config_intr,
.driver = {
.owner = THIS_MODULE,
},
--
1.8.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
2014-03-27 6:18 [PATCH] phy/at8031: enable at8031 to work on interrupt mode Zhao Qiang
@ 2014-03-27 11:52 ` Sergei Shtylyov
2014-03-28 7:36 ` qiang.zhao
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2014-03-27 11:52 UTC (permalink / raw)
To: Zhao Qiang, linuxppc-dev, netdev, B07421
Cc: mugunthanvnm, linux-kernel, helmut.schaa, zonque, R63061, davem
Hello.
On 27-03-2014 10:18, Zhao Qiang wrote:
> The at8031 can work on polling mode and interrupt mode.
> Add ack_interrupt and config intr funcs to enable
> interrupt mode for it.
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index bc71947..d034ef5 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
[...]
> @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device *phydev)
> return 0;
> }
>
> +static int at803x_ack_interrupt(struct phy_device *phydev)
> +{
> + int err;
> +
> + err = phy_read(phydev, AT803X_INSR);
Could make this an initializer...
> +
> + return (err < 0) ? err : 0;
> +}
> +
> +static int at803x_config_intr(struct phy_device *phydev)
> +{
> + int err;
> + int value;
> +
> + value = phy_read(phydev, AT803X_INER);
> +
> + if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
> + err = phy_write(phydev, AT803X_INER,
> + (value | AT803X_INER_INIT));
Inner parens not needed.
> + else
> + err = phy_write(phydev, AT803X_INER, value);
Why are you not clearing the bits here? Why write back what has been read
at all?
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
2014-03-27 11:52 ` Sergei Shtylyov
@ 2014-03-28 7:36 ` qiang.zhao
2014-03-28 18:09 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: qiang.zhao @ 2014-03-28 7:36 UTC (permalink / raw)
To: Sergei Shtylyov, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, Scott Wood
Cc: mugunthanvnm@ti.com, linux-kernel@vger.kernel.org,
helmut.schaa@googlemail.com, zonque@gmail.com,
davem@davemloft.net, Xiaobo Xie
On Thursday, March 27, 2014 7:53 PM, Sergei Shtylyov wrote:
> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: Thursday, March 27, 2014 7:53 PM
> To: Zhao Qiang-B45475; linuxppc-dev@lists.ozlabs.org;
> netdev@vger.kernel.org; Wood Scott-B07421
> Cc: linux-kernel@vger.kernel.org; davem@davemloft.net;
> mugunthanvnm@ti.com; zonque@gmail.com; helmut.schaa@googlemail.com; Xie
> Xiaobo-R63061
> Subject: Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
>=20
> Hello.
>=20
> On 27-03-2014 10:18, Zhao Qiang wrote:
>=20
> > The at8031 can work on polling mode and interrupt mode.
> > Add ack_interrupt and config intr funcs to enable interrupt mode for
> > it.
>=20
> > Signed-off-by: Zhao Qiang <B45475@freescale.com>
> > ---
> > drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
>=20
> > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index
> > bc71947..d034ef5 100644
> > --- a/drivers/net/phy/at803x.c
> > +++ b/drivers/net/phy/at803x.c
> [...]
> > @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device
> *phydev)
> > return 0;
> > }
> >
> > +static int at803x_ack_interrupt(struct phy_device *phydev) {
> > + int err;
> > +
> > + err =3D phy_read(phydev, AT803X_INSR);
>=20
> Could make this an initializer...
Thank you very much. However I have no idea about "make this an initializer=
".
>=20
> > +
> > + return (err < 0) ? err : 0;
> > +}
> > +
> > +static int at803x_config_intr(struct phy_device *phydev) {
> > + int err;
> > + int value;
> > +
> > + value =3D phy_read(phydev, AT803X_INER);
> > +
> > + if (phydev->interrupts =3D=3D PHY_INTERRUPT_ENABLED)
> > + err =3D phy_write(phydev, AT803X_INER,
> > + (value | AT803X_INER_INIT));
>=20
> Inner parens not needed.
>=20
> > + else
> > + err =3D phy_write(phydev, AT803X_INER, value);
>=20
> Why are you not clearing the bits here? Why write back what has been
> read at all?
>=20
> WBR, Sergei
>=20
>=20
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
2014-03-28 7:36 ` qiang.zhao
@ 2014-03-28 18:09 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2014-03-28 18:09 UTC (permalink / raw)
To: qiang.zhao@freescale.com, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, Scott Wood
Cc: mugunthanvnm@ti.com, linux-kernel@vger.kernel.org,
helmut.schaa@googlemail.com, zonque@gmail.com,
davem@davemloft.net, Xiaobo Xie
Hello.
On 03/28/2014 10:36 AM, qiang.zhao@freescale.com wrote:
>>> The at8031 can work on polling mode and interrupt mode.
>>> Add ack_interrupt and config intr funcs to enable interrupt mode for
>>> it.
>>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>>> ---
>>> drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
>>> 1 file changed, 30 insertions(+)
>>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index
>>> bc71947..d034ef5 100644
>>> --- a/drivers/net/phy/at803x.c
>>> +++ b/drivers/net/phy/at803x.c
>> [...]
>>> @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device
>> *phydev)
>>> return 0;
>>> }
>>>
>>> +static int at803x_ack_interrupt(struct phy_device *phydev) {
>>> + int err;
>>> +
>>> + err = phy_read(phydev, AT803X_INSR);
>> Could make this an initializer...
> Thank you very much. However I have no idea about "make this an initializer".
int err = phy_read(phydev, AT803X_INSR);
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] phy/at8031: enable at8031 to work on interrupt mode
@ 2014-03-26 6:45 Zhao Qiang
2014-03-26 18:13 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Zhao Qiang @ 2014-03-26 6:45 UTC (permalink / raw)
To: linuxppc-dev, B07421; +Cc: Zhao Qiang, R63061
The at8031 can work on polling mode and interrupt mode.
Add ack_interrupt and config intr funcs to enable
interrupt mode for it.
Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index bc71947..d034ef5 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -27,6 +27,9 @@
#define AT803X_MMD_ACCESS_CONTROL 0x0D
#define AT803X_MMD_ACCESS_CONTROL_DATA 0x0E
#define AT803X_FUNC_DATA 0x4003
+#define AT803X_INER 0x0012
+#define AT803X_INER_INIT 0xec00
+#define AT803X_INSR 0x0013
#define AT803X_DEBUG_ADDR 0x1D
#define AT803X_DEBUG_DATA 0x1E
#define AT803X_DEBUG_SYSTEM_MODE_CTRL 0x05
@@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device *phydev)
return 0;
}
+static int at803x_ack_interrupt(struct phy_device *phydev)
+{
+ int err;
+
+ err = phy_read(phydev, AT803X_INSR);
+
+ return (err < 0) ? err : 0;
+}
+
+static int at803x_config_intr(struct phy_device *phydev)
+{
+ int err;
+ int value;
+
+ value = phy_read(phydev, AT803X_INER);
+
+ if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
+ err = phy_write(phydev, AT803X_INER,
+ (value | AT803X_INER_INIT));
+ else
+ err = phy_write(phydev, AT803X_INER, value);
+
+ return err;
+}
+
static struct phy_driver at803x_driver[] = {
{
/* ATHEROS 8035 */
@@ -240,6 +268,8 @@ static struct phy_driver at803x_driver[] = {
.flags = PHY_HAS_INTERRUPT,
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
+ .ack_interrupt = &at803x_ack_interrupt,
+ .config_intr = &at803x_config_intr,
.driver = {
.owner = THIS_MODULE,
},
--
1.8.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode
2014-03-26 6:45 Zhao Qiang
@ 2014-03-26 18:13 ` Scott Wood
0 siblings, 0 replies; 6+ messages in thread
From: Scott Wood @ 2014-03-26 18:13 UTC (permalink / raw)
To: Zhao Qiang; +Cc: B07421, R63061, linuxppc-dev
On Wed, 2014-03-26 at 14:45 +0800, Zhao Qiang wrote:
> The at8031 can work on polling mode and interrupt mode.
> Add ack_interrupt and config intr funcs to enable
> interrupt mode for it.
>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
This needs to go to the netdev maintainer/list.
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-28 17:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-27 6:18 [PATCH] phy/at8031: enable at8031 to work on interrupt mode Zhao Qiang
2014-03-27 11:52 ` Sergei Shtylyov
2014-03-28 7:36 ` qiang.zhao
2014-03-28 18:09 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2014-03-26 6:45 Zhao Qiang
2014-03-26 18:13 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).