From: Andrew Donnellan <ajd@linux.ibm.com>
To: Nathan Lynch <nathanl@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: aik@ozlabs.ru, tyreld@linux.ibm.com, brking@linux.ibm.com,
aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH 4/6] powerpc/rtas: move syscall filter setup into separate function
Date: Fri, 15 Jan 2021 16:49:44 +1100 [thread overview]
Message-ID: <5347b6e7-0c7a-f65d-29d1-e3d58543df49@linux.ibm.com> (raw)
In-Reply-To: <20210114220004.1138993-5-nathanl@linux.ibm.com>
On 15/1/21 9:00 am, Nathan Lynch wrote:
> Reduce conditionally compiled sections within rtas_initialize() by
> moving the filter table initialization into its own function already
> guarded by CONFIG_PPC_RTAS_FILTER. No behavior change intended.
>
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
> +static void __init rtas_syscall_filter_init(void)
> +{
> + unsigned int i;
> +
> + for (i = 0; i < ARRAY_SIZE(rtas_filters); i++) {
> + rtas_filters[i].token = rtas_token(rtas_filters[i].name);
> + }
> +
> +}
Unnecessary empty line, but vitally important braces :)
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2021-01-15 5:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 21:59 [PATCH 0/6] powerpc/rtas: miscellaneous cleanups, user region allocation Nathan Lynch
2021-01-14 21:59 ` [PATCH 1/6] powerpc/rtas: improve ppc_rtas_rmo_buf_show documentation Nathan Lynch
2021-01-15 4:38 ` Alexey Kardashevskiy
2021-01-15 5:50 ` Andrew Donnellan
2021-01-14 22:00 ` [PATCH 2/6] powerpc/rtas-proc: remove unused RMO_READ_BUF_MAX Nathan Lynch
2021-01-15 4:38 ` Alexey Kardashevskiy
2021-01-15 5:52 ` Andrew Donnellan
2021-01-14 22:00 ` [PATCH 3/6] powerpc/rtas: remove ibm_suspend_me_token Nathan Lynch
2021-01-15 4:38 ` Alexey Kardashevskiy
2021-01-15 5:52 ` Andrew Donnellan
2021-01-14 22:00 ` [PATCH 4/6] powerpc/rtas: move syscall filter setup into separate function Nathan Lynch
2021-01-15 4:39 ` Alexey Kardashevskiy
2021-01-15 16:04 ` Nathan Lynch
2021-01-15 5:49 ` Andrew Donnellan [this message]
2021-01-14 22:00 ` [PATCH 5/6] powerpc/rtas: rename RTAS_RMOBUF_MAX to RTAS_USER_REGION_SIZE Nathan Lynch
2021-01-15 4:38 ` Alexey Kardashevskiy
2021-01-15 15:56 ` Nathan Lynch
2021-01-18 4:15 ` Alexey Kardashevskiy
2021-01-20 1:17 ` Nathan Lynch
2021-01-20 5:05 ` Alexey Kardashevskiy
2021-01-21 15:17 ` Nathan Lynch
2021-01-15 6:10 ` Andrew Donnellan
2021-01-15 12:04 ` kernel test robot
2021-01-14 22:00 ` [PATCH 6/6] powerpc/rtas: constrain user region allocation to RMA Nathan Lynch
2021-01-15 4:38 ` Alexey Kardashevskiy
2021-01-15 15:38 ` Nathan Lynch
2021-01-18 4:12 ` Alexey Kardashevskiy
2021-01-20 0:39 ` Nathan Lynch
2021-01-20 4:49 ` Alexey Kardashevskiy
2021-01-20 12:06 ` Michael Ellerman
2021-01-21 15:27 ` Nathan Lynch
2021-01-23 1:54 ` Alexey Kardashevskiy
2021-01-19 9:00 ` Michael Ellerman
2021-01-19 21:00 ` Nathan Lynch
2021-01-20 12:13 ` Michael Ellerman
2021-01-21 0:26 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5347b6e7-0c7a-f65d-29d1-e3d58543df49@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=aneesh.kumar@linux.ibm.com \
--cc=brking@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).