From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by ozlabs.org (Postfix) with ESMTP id ABE73140093 for ; Tue, 15 Apr 2014 04:59:00 +1000 (EST) Message-ID: <534C2FEB.2000803@canonical.com> Date: Mon, 14 Apr 2014 14:58:51 -0400 From: Joseph Salisbury MIME-Version: 1.0 To: linux-kernel@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org Subject: Re: [PATCH 1/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512. References: <84356b1cb9452226d54641a71e4b1363e78d4417.1397260362.git.joseph.salisbury@canonical.com> In-Reply-To: <84356b1cb9452226d54641a71e4b1363e78d4417.1397260362.git.joseph.salisbury@canonical.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: linuxppc-dev@lists.ozlabs.org, anton@samba.org, stable@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/14/2014 11:30 AM, Joseph Salisbury wrote: > BugLink: http://bugs.launchpad.net/bugs/1306677 > > While booting the PPC64EL kernel, the command line gets truncated to 512 characters. This is due to a hard limit of 512 defined for COMMAND_LINE_SIZE. It would be beneficial to have a command line longer than 512 characters, as iscsi targets and cloud-init parameters are passed through the kernel command line. > > Signed-off-by: Joseph Salisbury > Cc: Benjamin Herrenschmidt (supporter:LINUX FOR POWERPC...) > Cc: Paul Mackerras (supporter:LINUX FOR POWERPC...) > Cc: linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC...) > Cc: linux-kernel@vger.kernel.org (open list) > Cc: stable@vger.kernel.org > > --- > arch/powerpc/boot/ops.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/boot/ops.h b/arch/powerpc/boot/ops.h > index b3218ce..5a01fb1 100644 > --- a/arch/powerpc/boot/ops.h > +++ b/arch/powerpc/boot/ops.h > @@ -15,7 +15,7 @@ > #include "types.h" > #include "string.h" > > -#define COMMAND_LINE_SIZE 512 > +#define COMMAND_LINE_SIZE 2048 > #define MAX_PATH_LEN 256 > #define MAX_PROP_LEN 256 /* What should this be? */ > After further review, it appears ppc does not actually use the define in the ppc headers but uses the common generic default(include/uapi/asm-generic/setup.h). COMMAND_LINE_SIZE should probably become a kernel config option. Do folks agree that is the correct thing to do? If so, I can re-work the patch. Thanks, Joe