From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org
Cc: Nathan Lynch <nathanl@linux.ibm.com>,
Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries
Date: Thu, 18 Mar 2021 06:59:01 -0300 [thread overview]
Message-ID: <534b5b65-2267-2032-4490-9a5ae14a5960@gmail.com> (raw)
In-Reply-To: <b9e259d0-0d28-d5bf-bc85-05d42b352943@kaod.org>
On 3/18/21 4:28 AM, Cédric Le Goater wrote:
>> Also we've been using it for several years and I don't think we should
>> risk breaking anything by changing the value now.
>
> I guess we can leave it that way. Please read the commit log of
> the second patch (not tagged as a v2 ...).
>
> But we should remove ibm,chip-id from QEMU since the property does
> not exist on PAPR and that the calculation is anyhow very broken.
I am a strong advocate of getting rid of ibm,chip-id in QEMU. That said,
we need to make sure that the current problem with CPU topologies, that
I reported in that other thread, can be fixed without it.
Thanks,
DHB
>
> Thanks,
>
> C.
>
next prev parent reply other threads:[~2021-03-18 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 14:31 [PATCH] powerpc/numa: Fix topology_physical_package_id() on pSeries Cédric Le Goater
2021-03-15 13:08 ` Greg Kurz
2021-03-15 15:12 ` Daniel Henrique Barboza
2021-03-15 16:16 ` Cédric Le Goater
2021-03-15 17:36 ` Daniel Henrique Barboza
2021-03-16 5:23 ` Srikar Dronamraju
2021-03-16 11:28 ` Srikar Dronamraju
2021-03-16 12:28 ` Cédric Le Goater
2021-03-18 2:26 ` Michael Ellerman
2021-03-18 7:28 ` Cédric Le Goater
2021-03-18 9:59 ` Daniel Henrique Barboza [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-16 12:24 Cédric Le Goater
2021-03-22 5:19 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534b5b65-2267-2032-4490-9a5ae14a5960@gmail.com \
--to=danielhb413@gmail.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).