From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5F078140082 for ; Tue, 22 Apr 2014 18:32:41 +1000 (EST) Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Apr 2014 18:32:39 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 0C32D2BB0040 for ; Tue, 22 Apr 2014 18:32:37 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s3M8WLBu65994886 for ; Tue, 22 Apr 2014 18:32:22 +1000 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s3M8WZSa011210 for ; Tue, 22 Apr 2014 18:32:36 +1000 Message-ID: <53562921.6050300@linux.vnet.ibm.com> Date: Tue, 22 Apr 2014 14:02:33 +0530 From: Vasant Hegde MIME-Version: 1.0 To: Anton Blanchard , benh@kernel.crashing.org, paulus@samba.org, stewart@linux.vnet.ibm.com Subject: Re: [PATCH 6/6] powerpc/powernv: Fix little endian issues in OPAL dump code References: <1398142887-24109-1-git-send-email-anton@samba.org> <1398142887-24109-6-git-send-email-anton@samba.org> In-Reply-To: <1398142887-24109-6-git-send-email-anton@samba.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/22/2014 10:31 AM, Anton Blanchard wrote: > Signed-off-by: Anton Blanchard > --- > arch/powerpc/include/asm/opal.h | 4 ++-- > arch/powerpc/platforms/powernv/opal-dump.c | 13 +++++++++---- > 2 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h > index afb0fed..66ad7a7 100644 > --- a/arch/powerpc/include/asm/opal.h > +++ b/arch/powerpc/include/asm/opal.h > @@ -868,8 +868,8 @@ int64_t opal_validate_flash(uint64_t buffer, uint32_t *size, uint32_t *result); > int64_t opal_manage_flash(uint8_t op); > int64_t opal_update_flash(uint64_t blk_list); > int64_t opal_dump_init(uint8_t dump_type); > -int64_t opal_dump_info(uint32_t *dump_id, uint32_t *dump_size); > -int64_t opal_dump_info2(uint32_t *dump_id, uint32_t *dump_size, uint32_t *dump_type); > +int64_t opal_dump_info(__be32 *dump_id, __be32 *dump_size); > +int64_t opal_dump_info2(__be32 *dump_id, __be32 *dump_size, __be32 *dump_type); > int64_t opal_dump_read(uint32_t dump_id, uint64_t buffer); > int64_t opal_dump_ack(uint32_t dump_id); Shouldn't we change above two functions as well ? > int64_t opal_dump_resend_notification(void); > diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c > index f0b4724..788a197 100644 > --- a/arch/powerpc/platforms/powernv/opal-dump.c > +++ b/arch/powerpc/platforms/powernv/opal-dump.c > @@ -209,15 +209,20 @@ static struct kobj_type dump_ktype = { > .default_attrs = dump_default_attrs, > }; > > -static int64_t dump_read_info(uint32_t *id, uint32_t *size, uint32_t *type) > +static int64_t dump_read_info(uint32_t *dump_id, uint32_t *dump_size, uint32_t *dump_type) > { > + __be32 id, size, type; > int rc; > - *type = 0xffffffff; > > - rc = opal_dump_info2(id, size, type); > + type = cpu_to_be32(0xffffffff); > > + rc = opal_dump_info2(&id, &size, &type); > if (rc == OPAL_PARAMETER) > - rc = opal_dump_info(id, size); > + rc = opal_dump_info(&id, &size); > + > + *dump_id = be32_to_cpu(id); > + *dump_size = be32_to_cpu(size); > + *dump_type = be32_to_cpu(type); > Should we convert ID back to BE format in dump_send_ack() ? -Vasant > if (rc) > pr_warn("%s: Failed to get dump info (%d)\n", >